Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in session info #143

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix regression in session info #143

merged 1 commit into from
Jan 19, 2024

Conversation

sethterashima
Copy link
Collaborator

Description

Commit beb8735 introduced a regression that prevents clients from establishing session info on connections that are not cached. It caused a handshake to one domain to be cancelled when a handshake to another domain succeeded.

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.

@ThomasAlxDmy
Copy link
Contributor

ThomasAlxDmy commented Jan 19, 2024 •
edited
Loading

Is there no tests for this?

Fix regression in session info
a55d862 
Commit beb8735 introduced a
regression that prevents clients from establishing session info on
connections that are not cached. It caused a handshake to one domain to
be cancelled when a handshake to another domain succeeded.
@sethterashima sethterashima force-pushed the fix-parallel-handshake-regression branch from 9843bd4 to a55d862 Compare January 19, 2024 23:06
@sethterashima sethterashima merged commit 7c9d6d8 into teslamotors:main Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinoamr avinoamr avinoamr approved these changes

@aaronpkahn aaronpkahn aaronpkahn approved these changes

@ThomasAlxDmy ThomasAlxDmy ThomasAlxDmy approved these changes

@derekargueta derekargueta derekargueta approved these changes

@agbpatro agbpatro agbpatro approved these changes

@thefireblade thefireblade thefireblade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sethterashima @ThomasAlxDmy @avinoamr @aaronpkahn @derekargueta @agbpatro @thefireblade