Fix more clang-tidy errors

tesseract-robotics · Mar 7, 2024 · 2670523 · 2670523
1 parent e84ca11
commit 2670523
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/tesseract_motion_planners/descartes/src/deserialize.cpp b/tesseract_motion_planners/descartes/src/deserialize.cpp
@@ -42,7 +42,7 @@ namespace tesseract_planning
 DescartesDefaultPlanProfile<double> descartesPlanParser(const tinyxml2::XMLElement& xml_element)
 {
   const tinyxml2::XMLElement* descartes_plan_element = xml_element.FirstChildElement("DescartesPlanProfile");
-  return DescartesDefaultPlanProfile<double>(*descartes_plan_element);
+  return { *descartes_plan_element };
 }
 
 DescartesDefaultPlanProfile<double> descartesPlanFromXMLElement(const tinyxml2::XMLElement* profile_xml)

diff --git a/tesseract_motion_planners/descartes/src/serialize.cpp b/tesseract_motion_planners/descartes/src/serialize.cpp
@@ -74,7 +74,7 @@ std::string toXMLString(const DescartesPlanProfile<double>& plan_profile)
   std::shared_ptr<tinyxml2::XMLDocument> doc = toXMLDocument(plan_profile);
   tinyxml2::XMLPrinter printer;
   doc->Print(&printer);
-  return std::string(printer.CStr());
+  return { printer.CStr() };
 }
 
 }  // namespace tesseract_planning
diff --git a/...tion_planners/trajopt/include/tesseract_motion_planners/trajopt/trajopt_waypoint_config.h b/...tion_planners/trajopt/include/tesseract_motion_planners/trajopt/trajopt_waypoint_config.h
@@ -31,6 +31,7 @@
 
 namespace tinyxml2
 {
+// NOLINTNEXTLINE(cppcoreguidelines-virtual-class-destructor)
 class XMLElement;
 class XMLDocument;
 }  // namespace tinyxml2