Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle cartesian waypoints in SimplePlannerFixedSizeAssignPlanProfile #447

Closed
wants to merge 2 commits into from

Conversation

rjoomen
Copy link
Contributor

@rjoomen rjoomen commented Mar 18, 2024

Previously, when the only second position was cartesian, the SimplePlannerFixedSizeAssignPlanProfile would take the joint position of the first position as seed, or, if both were cartesian, it would take the environment state as seed, leading to strange planning results.
With this PR the 'seed' of the second cartesian position is used if available, or the IK of the second position is calculated using either the first position or the environment state as seed.

@rjoomen rjoomen requested a review from Levi-Armstrong March 18, 2024 16:22
@rjoomen
Copy link
Contributor Author

rjoomen commented Mar 18, 2024

If you agree with this PR I'll fix the tests.

@Levi-Armstrong
Copy link
Contributor

I will review today

@Levi-Armstrong
Copy link
Contributor

I do not believe this one is intended to run inverse kinematics.

@Levi-Armstrong
Copy link
Contributor

I do believe it should be updated to leverage the seed but should not run inverse kinematics. If I remember correctly this was intended to just used the current state.

@rjoomen
Copy link
Contributor Author

rjoomen commented May 3, 2024

I do believe it should be updated to leverage the seed but should not run inverse kinematics. If I remember correctly this was intended to just used the current state.

OK, but shouldn't it be called SimplePlannerFixedSizeAssignNoIKPlanProfile instead of SimplePlannerFixedSizeAssignPlanProfile, for clarity and to match SimplePlannerLVSNoIKPlanProfile?

@Levi-Armstrong
Copy link
Contributor

I do believe it should be updated to leverage the seed but should not run inverse kinematics. If I remember correctly this was intended to just used the current state.

OK, but shouldn't it be called SimplePlannerFixedSizeAssignNoIKPlanProfile instead of SimplePlannerFixedSizeAssignPlanProfile, for clarity and to match SimplePlannerLVSNoIKPlanProfile?

I am good with changing the name to make it more clear.

@rjoomen
Copy link
Contributor Author

rjoomen commented May 29, 2024

I've done more work, including the NoIK renaming, and added it all to #448. Closing this PR.

@rjoomen rjoomen closed this May 29, 2024
@rjoomen rjoomen deleted the spfsapp_cartesian branch May 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants