-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print a collision summary to status of failed contact check #543
base: master
Are you sure you want to change the base?
Conversation
Not that I am against adding this, just wanted mention here. There is now a log file that can be generated and tesseract_qt has a viewer that allows you to inspect a lot of this type of information. |
I was unaware of this, I can't seem to get it to work in RVIZ with tesseract_ros2. I was able to save and then load a log file (although it was 6.6 GB), and I see things about viewing trajectories and toolpaths in the widget, but nothing actually displays. In general my proposed change just helps for seeing things at a glance. I am saving all my programs at each step with unique names and publishing them all to the trajectory viewer, so I can debug things nicely, but it can be hard to dig through them all to find the collision and there are so many terminal logs that I can't easily find the collision report. |
I think something that would be really cool is to have a tesseract logger object that optionally prints stuff to the terminal, but also stores all the logs to a map based on UUIDs of tasks/graphs. Then all the terminal logs could be exported into unique files, making it easy to debug an individual task even when multiple threads are running at the same time |
The widget has a context menu that allows you to right click on composite instruction and send as a tool path or joint trajectory. I need to add more like sending the collision results, etc. |
const auto& contact_map = contacts[i]; | ||
if (!contact_map.empty()) | ||
{ | ||
ss << contact_map.getSummary() << "\n"; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see this blowing up. Should we just print the first contact summary?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #543 +/- ##
==========================================
+ Coverage 78.41% 78.43% +0.01%
==========================================
Files 252 252
Lines 13734 13746 +12
==========================================
+ Hits 10770 10782 +12
Misses 2964 2964 |
Better debugging at a glance for dot graphs. Depends on tesseract-robotics/tesseract#1079