Added support and basic test for template strings #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2015 13:45
THIS NEEDS TO BE CHANGED TO THE NEW COMPLEXION-JS VERSION BEFORE MERGE. THIS IS ONLY TO SUPPORT TESTS ON TRAVIS-CI
|
The build failed because the jslint package requires glob ^4.3.5 and node 0.8 does not understand "^". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires tests-always-included/complexion-js#1 to work correctly. Supports work in #12.
I am open to adding more tests for this behavior. In my testing on a medium ES6 codebase, I haven't noticed any issues and I'm not sure what other test cases we would need.