Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase upstream #3

Closed
wants to merge 120 commits into from
Closed

Rebase upstream #3

wants to merge 120 commits into from

Conversation

kirbycool
Copy link

@kirbycool kirbycool commented Aug 2, 2024 •
edited
Loading

We need the new FCM api changes from here rpush#660

benlangfeld and others added 30 commits October 1, 2020 08:52
@benlangfeld
Reference current interface in config template
085f688 
Fixes rpush#526
@hsbt
Fixed typo with misspell
32360d8
@aried3r
Merge pull request rpush#575 from hsbt/fix-typo
4c70cc0 
Fixed typo with misspell
@jkraemer
support for webpush with VAPID
767d5b7
@benlangfeld
Merge pull request rpush#574 from planio-gmbh/feature/webpush-vapid
a9fc8a5 
support for Webpush with VAPID
@jamestjw
Fix APNS2 documentation in README
9eeb10e
@benlangfeld
Valid Ruby syntax
973019b
@benlangfeld
Merge pull request rpush#578 from jamestjw/master
07f33fb 
Fix APNS2 documentation in README
@jkraemer
set apns-* headers in apns2 delivery
c9681be
@jkraemer
amend README
7e3113a 
point out that the bundle id does not have to be transferred with every
notification when it's set on the application level.
@jas14
Replace deprecated << with ActiveModel::Errors#add
277d282
@jas14
Use \A, \z instead of ^, $ to validate device token
c15ff9d
@benlangfeld
Merge pull request rpush#582 from splitwise/joe/rails-61
909e49c 
Fix more Rails 6.1 deprecation warnings
@benlangfeld
Merge pull request rpush#579 from planio-gmbh/feature/apns2-default-h…
d822211 
…eaders

Feature/apns2 default headers
@gregblake
Adds failing specs for Rpush::Client::ActiveRecord::Apnsp8::Notification
b081c5f 
These specs are failing because:

* APNS v1 imposes a validation payload size limit of 2kb. On APNS2 and
APNSp8, the payload limit increases to 4kb (any APNS notification
delivered via http/2 has a payload limit of 4kb).
* When using APNSp8, Rpush is validating the notification payload size
based on APNS v1 size limits (2kb), rather than APNS v2 size limits (4kb).

https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CreatingtheNotificationPayload.html

```
Failures:

  1) Rpush::Client::ActiveRecord::Apnsp8::Notification should validate the length of the binary conversion of the notification
     Got 3 failures:

     1.1) Failure/Error: expect(notification.valid?).to be_truthy

            expected: truthy value
                 got: false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/active_record/apnsp8/notification_spec.rb:17:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

     1.2) Failure/Error: expect(notification.errors[:base]).to be_empty
            expected `["APN notification cannot be larger than 2048 bytes. Try condensing your alert and device attributes."].empty?` to return true, got false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/active_record/apnsp8/notification_spec.rb:18:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

     1.3) Failure/Error: expect(notification.errors[:base].include?("APN notification cannot be larger than 4096 bytes. Try condensing your alert and device attributes.")).to be_truthy

            expected: truthy value
                 got: false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/active_record/apnsp8/notification_spec.rb:22:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

Finished in 34.11 seconds (files took 2.53 seconds to load)
778 examples, 1 failure

Failed examples:

rspec ./spec/unit/client/active_record/apnsp8/notification_spec.rb:9 # Rpush::Client::ActiveRecord::Apnsp8::Notification should validate the length of the binary conversion of the notification
```
@gregblake
Rpush::Client::ActiveRecord::Apnsp8::Notification valid up to 4kb
7da2c10
@gregblake
Adds failing specs for Rpush::Client::Redis::Apnsp8::Notification
e2c9168 
These specs are failing because:

* APNS v1 imposes a validation payload size limit of 2kb. On APNS2 and
APNSp8, the payload limit increases to 4kb (any APNS notification
delivered via http/2 has a payload limit of 4kb).
* When using APNSp8, Rpush is validating the notification payload size
based on APNS v1 size limits (2kb), rather than APNS v2 size limits (4kb).

https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CreatingtheNotificationPayload.html

```
Failures:

  1) Rpush::Client::Redis::Apnsp8::Notification should validate the length of the binary conversion of the notification
     Got 3 failures:

     1.1) Failure/Error: expect(notification.valid?).to be_truthy

            expected: truthy value
                 got: false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/redis/apnsp8/notification_spec.rb:18:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

     1.2) Failure/Error: expect(notification.errors[:base]).to be_empty
            expected `["APN notification cannot be larger than 2048 bytes. Try condensing your alert and device attributes."].empty?` to return true, got false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/redis/apnsp8/notification_spec.rb:19:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

     1.3) Failure/Error: expect(notification.errors[:base].include?("APN notification cannot be larger than 4096 bytes. Try condensing your alert and device attributes.")).to be_truthy

            expected: truthy value
                 got: false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/redis/apnsp8/notification_spec.rb:23:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

Finished in 34.69 seconds (files took 2.18 seconds to load)
779 examples, 1 failure

Failed examples:

rspec ./spec/unit/client/redis/apnsp8/notification_spec.rb:6 # Rpush::Client::Redis::Apnsp8::Notification should validate the length of the binary conversion of the notification
```
@gregblake
Rpush::Client::Redis::Apnsp8::Notification valid up to 4kb
1cb7c44
@gregblake
Cleans up Redis data
e7ea511
@gregblake
Only run these examples on the relevant adapter
d7a3f58
@benlangfeld
Merge pull request rpush#583 from gregblake/apns_p8_4kb_payload_limit
0dea768 
Bug fix: APNS P8 Notifications Are Marked as Invalid When the Payload Exceeds 2kb (2048 bytes)
@aried3r
Prepare v5.3.0 release
9cbfa5e
@andreaslillebo
Use net-http-persistent version compatible with Ruby 3
8cf6db5 
Version 4.0.0 of `net-http-persistent` is incompatible with Ruby 3.0. This was fixed in version 4.0.1.
@andreaslillebo
Fix hash being passed as keyword argument
bd4c432 
In Ruby 2.7, a Hash can automatically be converted to a keyword argument. In Ruby 3.0 however, attempting to do so will raise an ArgumentError.

See the following link for more details:
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
@andreaslillebo
Test on Ruby 3.0 & Rails 6.1
dce1ea9
@andreaslillebo
Exclude incompatible ruby & rails combinations from CI
e6334fc
@andreaslillebo
Ruby 3 is incompatible with Rails 5
d843926
@yltsrc
fix typo in README.md, notification must be Rpush::Apnsp8::Notificati…
c3b9073 
…on for Apnsp8
@benlangfeld
Merge pull request rpush#587 from yltsrc/update-readme-apnsp8-app
ba151ec 
fix typo in README.md
@aried3r
Merge pull request rpush#586 from andreaslillebo/ruby-3.0
1bde7b8
AnilRh and others added 26 commits January 22, 2024 09:09
@AnilRh
Merge branch 'master' into fcm-support-v2
b3cb24b 
* master:
  Bump rails-html-sanitizer from 1.4.2 to 1.4.3 (rpush#642)
  Bump rack from 2.2.3 to 2.2.3.1 (rpush#638)
  Stop auto-closing issues
@AnilRh
Fix - missing gcm interface
20a3fe4
@AnilRh
fix code formatting - no change
2f467bd
@AnilRh
Payload Data Size is now calculated based off the message data attribute
8f662c2 
Priority value is now using 'normal' or 'high' instead of numeric values
Dry Run option is not implemented so throws an exception
Mutable Content is not implemented so throws an exception
@AnilRh
Adding tests
3043dd7
@AnilRh
Removing debug line
0b18e5b
@AnilRh
Adding debug line requested in PR rpush#620
fb5d567 
Get tests working without all the ENV variables
@nigimaxx
Add properties to FCM App to allow operation without env vars
39040cb
@AnilRh
Merge pull request #1 from nigimaxx/fcm-support-v2
6a9e199 
Add properties to FCM App to allow operation without env vars
@AnilRh
Adding new attributes to redis model
576b336
@AnilRh
Adding 7.1 migration to active record tests. Updating Gemfile.lock
99b33af
@AnilRh
FCM returning error when data is sent in Android payload
6498354
@AnilRh
Moving notification keys to the correct location - only supporting An…
a5eccd6 
…droid
@AnilRh
As the FCM code moves around notification keys, it would be good to h…
4429f85 
…andle both stirng and symbol keys.
@AnilRh
- Calling hook fcm_invalid_device_token if we get an invalid token re…
fd260e5 
…sponse from FCM

- Adding specs for FCM daemon
- Clarifying error message
@AnilRh
Adding a google credential cache
3fdf3ca
@AnilRh
Fixing Logging
06aa50e
@AnilRh
Adding a google credential cache
ccecae3
@AnilRh
Remove content_available from FCM implementation. It doesn't appear t…
4ab0185 
…o be suported in Android
@aried3r
Merge pull request rpush#660 from AnilRh/fcm-support-v2
5d576f4
@aried3r
Allow all of the CI matrix to run, even on failure
a3cb803
@kirbycool
Use ActiveRecord to fetch Apps instead of Redis.
4886f40
@kirbycool
TA-28669. Stop saving all rpush IDs to set.
e2ddafa
@kirbycool
TA-28669. Stop saving all rpush feedback IDs to set.
4b0cb4e
@kirbycool
Add temp logging to debug SSL error.
fb21155
@yanithx @kirbycool
BUGS-1850. Retry after Errno::ECONNRESET
3592d72
@kirbycool
Copy link
Author

kirbycool commented Aug 5, 2024 •
edited
Loading

Rails 5.1 support was dropped here. We can probably still get it to work, but there's no testing for old rails versions.
rpush#597

The other option is to cherry-pick the FCM classes.

@kirbycool kirbycool closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.