Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase upstream #3

Closed
wants to merge 120 commits into from
Closed

Rebase upstream #3

wants to merge 120 commits into from

Commits on Oct 1, 2020

  1. Reference current interface in config template 

    Fixes rpush#526
    @benlangfeld
    benlangfeld authored Oct 1, 2020
    Configuration menu
    Copy the full SHA
    085f688 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Fixed typo with misspell

    @hsbt
    hsbt committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    32360d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. Merge pull request rpush#575 from hsbt/fix-typo 

    Fixed typo with misspell
    @aried3r
    aried3r authored Oct 28, 2020
    Configuration menu
    Copy the full SHA
    4c70cc0 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2020

  1. support for webpush with VAPID

    @jkraemer
    jkraemer committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    767d5b7 View commit details
    Browse the repository at this point in the history

  2. Merge pull request rpush#574 from planio-gmbh/feature/webpush-vapid 

    support for Webpush with VAPID
    @benlangfeld
    benlangfeld authored Oct 31, 2020
    Configuration menu
    Copy the full SHA
    a9fc8a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Fix APNS2 documentation in README

    @jamestjw
    jamestjw committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    9eeb10e View commit details
    Browse the repository at this point in the history

  2. Valid Ruby syntax

    @benlangfeld
    benlangfeld authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    973019b View commit details
    Browse the repository at this point in the history

  3. Merge pull request rpush#578 from jamestjw/master 

    Fix APNS2 documentation in README
    @benlangfeld
    benlangfeld authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    07f33fb View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. set apns-* headers in apns2 delivery

    @jkraemer
    jkraemer committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    c9681be View commit details
    Browse the repository at this point in the history

  2. amend README 

    point out that the bundle id does not have to be transferred with every
notification when it's set on the application level.
    @jkraemer
    jkraemer committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    7e3113a View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Replace deprecated << with ActiveModel::Errors#add

    @jas14
    jas14 committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    277d282 View commit details
    Browse the repository at this point in the history

  2. Use \A, \z instead of ^, $ to validate device token

    @jas14
    jas14 committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    c15ff9d View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2020

  1. Merge pull request rpush#582 from splitwise/joe/rails-61 

    Fix more Rails 6.1 deprecation warnings
    @benlangfeld
    benlangfeld authored Dec 30, 2020
    Configuration menu
    Copy the full SHA
    909e49c View commit details
    Browse the repository at this point in the history

  2. Merge pull request rpush#579 from planio-gmbh/feature/apns2-default-h… 

    …eaders

Feature/apns2 default headers
    @benlangfeld
    benlangfeld authored Dec 30, 2020
    Configuration menu
    Copy the full SHA
    d822211 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2020

  1. Adds failing specs for Rpush::Client::ActiveRecord::Apnsp8::Notification 

    These specs are failing because:

* APNS v1 imposes a validation payload size limit of 2kb. On APNS2 and
APNSp8, the payload limit increases to 4kb (any APNS notification
delivered via http/2 has a payload limit of 4kb).
* When using APNSp8, Rpush is validating the notification payload size
based on APNS v1 size limits (2kb), rather than APNS v2 size limits (4kb).

https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CreatingtheNotificationPayload.html

```
Failures:

  1) Rpush::Client::ActiveRecord::Apnsp8::Notification should validate the length of the binary conversion of the notification
     Got 3 failures:

     1.1) Failure/Error: expect(notification.valid?).to be_truthy

            expected: truthy value
                 got: false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/active_record/apnsp8/notification_spec.rb:17:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

     1.2) Failure/Error: expect(notification.errors[:base]).to be_empty
            expected `["APN notification cannot be larger than 2048 bytes. Try condensing your alert and device attributes."].empty?` to return true, got false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/active_record/apnsp8/notification_spec.rb:18:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

     1.3) Failure/Error: expect(notification.errors[:base].include?("APN notification cannot be larger than 4096 bytes. Try condensing your alert and device attributes.")).to be_truthy

            expected: truthy value
                 got: false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/active_record/apnsp8/notification_spec.rb:22:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

Finished in 34.11 seconds (files took 2.53 seconds to load)
778 examples, 1 failure

Failed examples:

rspec ./spec/unit/client/active_record/apnsp8/notification_spec.rb:9 # Rpush::Client::ActiveRecord::Apnsp8::Notification should validate the length of the binary conversion of the notification
```
    @gregblake
    gregblake committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    b081c5f View commit details
    Browse the repository at this point in the history

  2. Rpush::Client::ActiveRecord::Apnsp8::Notification valid up to 4kb

    @gregblake
    gregblake committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    7da2c10 View commit details
    Browse the repository at this point in the history

  3. Adds failing specs for Rpush::Client::Redis::Apnsp8::Notification 

    These specs are failing because:

* APNS v1 imposes a validation payload size limit of 2kb. On APNS2 and
APNSp8, the payload limit increases to 4kb (any APNS notification
delivered via http/2 has a payload limit of 4kb).
* When using APNSp8, Rpush is validating the notification payload size
based on APNS v1 size limits (2kb), rather than APNS v2 size limits (4kb).

https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CreatingtheNotificationPayload.html

```
Failures:

  1) Rpush::Client::Redis::Apnsp8::Notification should validate the length of the binary conversion of the notification
     Got 3 failures:

     1.1) Failure/Error: expect(notification.valid?).to be_truthy

            expected: truthy value
                 got: false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/redis/apnsp8/notification_spec.rb:18:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

     1.2) Failure/Error: expect(notification.errors[:base]).to be_empty
            expected `["APN notification cannot be larger than 2048 bytes. Try condensing your alert and device attributes."].empty?` to return true, got false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/redis/apnsp8/notification_spec.rb:19:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

     1.3) Failure/Error: expect(notification.errors[:base].include?("APN notification cannot be larger than 4096 bytes. Try condensing your alert and device attributes.")).to be_truthy

            expected: truthy value
                 got: false
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:49:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:96:in `notify_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
          # ./spec/unit/client/redis/apnsp8/notification_spec.rb:23:in `block (2 levels) in <top (required)>'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `instance_exec'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:236:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:478:in `block in with_around_and_singleton_context_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:435:in `block in with_around_example_hooks'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:478:in `block in run'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-core-3.4.4/lib/rspec/core/example.rb:320:in `call'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:10:in `block in aggregate'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-support-3.4.1/lib/rspec/support.rb:103:in `with_failure_notifier'
          # /Users/greg/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rspec-expectations-3.4.0/lib/rspec/expectations/failure_aggregator.rb:8:in `aggregate'

Finished in 34.69 seconds (files took 2.18 seconds to load)
779 examples, 1 failure

Failed examples:

rspec ./spec/unit/client/redis/apnsp8/notification_spec.rb:6 # Rpush::Client::Redis::Apnsp8::Notification should validate the length of the binary conversion of the notification
```
    @gregblake
    gregblake committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    e2c9168 View commit details
    Browse the repository at this point in the history

  4. Rpush::Client::Redis::Apnsp8::Notification valid up to 4kb

    @gregblake
    gregblake committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    1cb7c44 View commit details
    Browse the repository at this point in the history

  5. Cleans up Redis data

    @gregblake
    gregblake committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    e7ea511 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. Only run these examples on the relevant adapter

    @gregblake
    gregblake committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    d7a3f58 View commit details
    Browse the repository at this point in the history

  2. Merge pull request rpush#583 from gregblake/apns_p8_4kb_payload_limit 

    Bug fix: APNS P8 Notifications Are Marked as Invalid When the Payload Exceeds 2kb (2048 bytes)
    @benlangfeld
    benlangfeld authored Jan 4, 2021
    Configuration menu
    Copy the full SHA
    0dea768 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Prepare v5.3.0 release

    @aried3r
    aried3r committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    9cbfa5e View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Use net-http-persistent version compatible with Ruby 3 

    Version 4.0.0 of `net-http-persistent` is incompatible with Ruby 3.0. This was fixed in version 4.0.1.
    @andreaslillebo
    andreaslillebo committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    8cf6db5 View commit details
    Browse the repository at this point in the history

  2. Fix hash being passed as keyword argument 

    In Ruby 2.7, a Hash can automatically be converted to a keyword argument. In Ruby 3.0 however, attempting to do so will raise an ArgumentError.

See the following link for more details:
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
    @andreaslillebo
    andreaslillebo committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    bd4c432 View commit details
    Browse the repository at this point in the history

  3. Test on Ruby 3.0 & Rails 6.1

    @andreaslillebo
    andreaslillebo committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    dce1ea9 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Exclude incompatible ruby & rails combinations from CI

    @andreaslillebo
    andreaslillebo committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    e6334fc View commit details
    Browse the repository at this point in the history

  2. Ruby 3 is incompatible with Rails 5

    @andreaslillebo
    andreaslillebo committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    d843926 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. fix typo in README.md, notification must be Rpush::Apnsp8::Notificati… 

    …on for Apnsp8
    @yltsrc
    yltsrc committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    c3b9073 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Merge pull request rpush#587 from yltsrc/update-readme-apnsp8-app 

    fix typo in README.md
    @benlangfeld
    benlangfeld authored Feb 12, 2021
    Configuration menu
    Copy the full SHA
    ba151ec View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Merge pull request rpush#586 from andreaslillebo/ruby-3.0

    @aried3r
    aried3r authored Feb 15, 2021
    Configuration menu
    Copy the full SHA
    1bde7b8 View commit details
    Browse the repository at this point in the history

  2. Prepare 5.4.0 release

    @aried3r
    aried3r committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    5cd2ddf View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Updates README to Apple's new EOL date for the APNs legacy binary pro… 

    …tocol (rpush#595)

* Updates README to Apple's new EOL date for the APNs legacy binary protocol

* Update README.md

Co-authored-by: Ben Langfeld <[email protected]>
    @gregblake @benlangfeld
    gregblake and benlangfeld authored Mar 4, 2021
    Configuration menu
    Copy the full SHA
    d81dfa3 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Drop support for Rails 5.0 and 5.1 (rpush#597)

    @ericsaupe
    ericsaupe authored Mar 15, 2021
    Configuration menu
    Copy the full SHA
    0dbf80b View commit details
    Browse the repository at this point in the history

  2. Fix silent APNS notifications for Apns2 and Apnsp8 (rpush#596)

    @shved270189
    shved270189 authored Mar 15, 2021
    Configuration menu
    Copy the full SHA
    7eb2967 View commit details
    Browse the repository at this point in the history

  3. Remove references and checks for unsupported versions of Rails (rpush… 

    …#599)
    @ericsaupe
    ericsaupe authored Mar 15, 2021
    Configuration menu
    Copy the full SHA
    42ef7b3 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Bump gemspec post_install_message (rpush#600)

    @fdocr
    fdocr authored Mar 17, 2021
    Configuration menu
    Copy the full SHA
    995a652 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Eliminate deprecated check 

    When Object#=~ is called on an Integer in Ruby 3.0, it always returns nil. It appears that #pluralize is only being used with Numeric values, so `count == 1` should be a sufficient check.
    @rofreg
    rofreg committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    a4c8518 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Fixed infinite loop issue with Apnsp8 delivery

    Jason Rush committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    6458168 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Bump activesupport version to 5.2 or later (rpush#610)

    @biow0lf
    biow0lf authored Apr 16, 2021
    Configuration menu
    Copy the full SHA
    f81b8fb View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Added a comment explaining the hard-coded ma concurrent streams

    Jason Rush committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    d61366a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Merge pull request rpush#608 from diminish7/apnsp8-delivery-loop-fix 

    Fixed infinite loop issue with Apnsp8 delivery
    @aried3r
    aried3r authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    85565e0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request rpush#602 from splitwise/rofreg/ruby-3.0-deprecati… 

    …on-fix

Eliminate deprecation warning in Ruby 3.0
    @aried3r
    aried3r authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    97ef4fe View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Make ActiveRecord validations work with Apns2 client (rpush#601)

    @favrik
    favrik authored May 6, 2021
    Configuration menu
    Copy the full SHA
    84647b4 View commit details
    Browse the repository at this point in the history

  2. Update dependencies

    @aried3r
    aried3r committed May 6, 2021
    Configuration menu
    Copy the full SHA
    d433b24 View commit details
    Browse the repository at this point in the history

  3. Prepare 6.0.0 release

    @aried3r
    aried3r committed May 6, 2021
    Configuration menu
    Copy the full SHA
    9f408b4 View commit details
    Browse the repository at this point in the history

  4. Remove .ruby-gemset file, obsolete

    @aried3r
    aried3r committed May 6, 2021
    Configuration menu
    Copy the full SHA
    3aa1130 View commit details
    Browse the repository at this point in the history

  5. Amend CHANGELOG.md

    @aried3r
    aried3r committed May 6, 2021
    Configuration menu
    Copy the full SHA
    ac44cea View commit details
    Browse the repository at this point in the history

  6. Merge pull request rpush#613 from rpush/ar/rpush_6.0

    @aried3r
    aried3r authored May 6, 2021
    Configuration menu
    Copy the full SHA
    256d1fb View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Implement GitHub Actions for CI

    @aried3r
    aried3r committed May 7, 2021
    Configuration menu
    Copy the full SHA
    e3b6a01 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2021

  1. Merge pull request rpush#615 from rpush/ar/github_actions 

    Switch to GitHub Actions for CI
    @aried3r
    aried3r authored May 8, 2021
    Configuration menu
    Copy the full SHA
    d914b07 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Prepare changelog for 6.0.0 [skip ci]

    @aried3r
    aried3r committed May 21, 2021
    Configuration menu
    Copy the full SHA
    7df8ff4 View commit details
    Browse the repository at this point in the history

  2. Merge pull request rpush#569 from rpush/benlangfeld-patch-1 

    Reference current interface in config template
    @aried3r
    aried3r authored May 21, 2021
    Configuration menu
    Copy the full SHA
    5f21e77 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Update README.md 

    Add Prometheus Exporter plugin link.
    @maxsz
    maxsz authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    22b9e68 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Merge pull request rpush#617 from equinux/master 

    Add Prometheus Exporter plugin link to README
    @aried3r
    aried3r authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    31ae99c View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Don't limit webpush registration keys (rpush#624) 

    Resolves rpush#623
    @treyrich
    treyrich authored Sep 29, 2021
    Configuration menu
    Copy the full SHA
    eb493bb View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Prepare 6.0.1 release

    @aried3r
    aried3r committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    3ab3a98 View commit details
    Browse the repository at this point in the history

  2. Add v6.0.1 change log [skip ci]

    @aried3r
    aried3r committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    92eeff4 View commit details
    Browse the repository at this point in the history

  3. Test with Rails 7.0.0.alpha2

    @aried3r
    aried3r committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    aba0ad6 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Merge pull request rpush#626 from rpush/ar/test_with_rails_7.0

    @aried3r
    aried3r authored Oct 13, 2021
    Configuration menu
    Copy the full SHA
    9a72cca View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Test with Rails 7.0.0.rc1

    @aried3r @gregblake
    aried3r authored and gregblake committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    bd1c0e6 View commit details
    Browse the repository at this point in the history

  2. Resolves a NoMethodError when running rpush init on Rails 7 

    Running `rpush init` results in the following error, beginning with
Rails version `v7.0.0.rc1`.

` undefined method `[]' for #<ActiveRecord::DatabaseConfigurations:0x00007f82dcdcc010> (NoMethodError)`

1. Create a new Rails app, using Rails version v7.0.0.rc1 or higher.
2. Add rpush to the Gemfile, and run `bundle install`.
3. Run `bundle exec rpush init`.

This exception could also occur on apps running Rails 7 that have been
running older versions of rpush older than 2.0.0 (when the app is
updated to a new version of rpush, users run `rpush init`).

The changes introduced on f88febe
trigger the exception:

https://github.com/rpush/rpush/runs/4545600006?check_suite_focus=true#step:6:13

```
/home/runner/work/rpush/rpush/lib/generators/templates/rpush_2_0_0_updates.rb:61:in `adapter_name': undefined method `[]' for #<ActiveRecord::DatabaseConfigurations:0x000055cead615a40 @Configurations=[#<ActiveRecord::DatabaseConfigurations::HashConfig:0x000055cead6156f8 @env_name="test", @name="primary", @configuration_hash={:adapter=>"postgresql", :database=>"rpush_test", :host=>"localhost", :username=>"postgres", :***"postgres"}>]> (NoMethodError)
```

`ActiveRecord::Base.configurations.to_h` was removed in Rails 7
in favor of `ActiveRecord::Base.configurations.configs_for`.

rails/rails@190f006
https://edgeguides.rubyonrails.org/7_0_release_notes.html#active-job-removals
https://www.bigbinary.com/blog/rails-6-changed-activerecord-base-configurations-result-to-an-object
    @gregblake
    gregblake committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    dd6eeb5 View commit details
    Browse the repository at this point in the history

  3. Resolves a NoMethodError in Daemon::Store::ActiveRecord.adapter_name 

    See the commit message on 27262d4
for more details about this change.
    @gregblake
    gregblake committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    e6ec521 View commit details
    Browse the repository at this point in the history

  4. Test with Rails 7.0.0.rc3

    @aried3r @gregblake
    aried3r authored and gregblake committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    87295af View commit details
    Browse the repository at this point in the history

  5. Test with Rails 7.0.0

    @aried3r @gregblake
    aried3r authored and gregblake committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    74e7ac4 View commit details
    Browse the repository at this point in the history

  6. Resolves Rails 7 Time.now.to_s deprecation warning

    @gregblake
    gregblake committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    56a5266 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Bumps Rails 7 Gemfile from 7.0.0.rc3 to 7.0.0

    @gregblake
    gregblake committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    f57e4b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Merge pull request rpush#629 from gregblake/rails_7_support

    @aried3r
    aried3r authored Jan 10, 2022
    Configuration menu
    Copy the full SHA
    7db415f View commit details
    Browse the repository at this point in the history

  2. Merge pull request rpush#630 from gregblake/resolve_deprecation_warning

    @aried3r
    aried3r authored Jan 10, 2022
    Configuration menu
    Copy the full SHA
    7670a6e View commit details
    Browse the repository at this point in the history

  3. Drop support for Ruby 2.3

    @aried3r
    aried3r committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    bd082b7 View commit details
    Browse the repository at this point in the history

  4. Merge pull request rpush#631 from rpush/ar/drop_ruby_2.3_support

    @aried3r
    aried3r authored Jan 10, 2022
    Configuration menu
    Copy the full SHA
    1ccb8d9 View commit details
    Browse the repository at this point in the history

  5. Test with Ruby 3.1

    @aried3r
    aried3r committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    94ac15a View commit details
    Browse the repository at this point in the history

  6. Use psych 3.x for Rails 6.0.x

    @aried3r
    aried3r committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    de7ad3c View commit details
    Browse the repository at this point in the history

  7. Merge pull request rpush#632 from rpush/ar/test_with_ruby_3.1

    @aried3r
    aried3r authored Jan 10, 2022
    Configuration menu
    Copy the full SHA
    e628102 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Opt-in to mfa requirement

    @aried3r
    aried3r committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    b799a68 View commit details
    Browse the repository at this point in the history

  2. Prepare 7.0.0 release

    @aried3r
    aried3r committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    a7eafec View commit details
    Browse the repository at this point in the history

  3. Update rubocop 

    Now that we dropped Ruby 2.3
    @aried3r
    aried3r committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    81e12b5 View commit details
    Browse the repository at this point in the history

  4. Update development dependencies

    @aried3r
    aried3r committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    afb4ad0 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. Fix deprecation warnings from the redis gem

    @sharang-d
    sharang-d committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    a87c27e View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. Merge pull request rpush#636 from sharang-d/fix-redis-deprecation-war… 

    …ning
    @aried3r
    aried3r authored Mar 2, 2022
    Configuration menu
    Copy the full SHA
    c0da089 View commit details
    Browse the repository at this point in the history

  2. Update modis development dependency

    @aried3r
    aried3r committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b5e6bd2 View commit details
    Browse the repository at this point in the history

  3. Update development dependencies

    @aried3r
    aried3r committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b259a66 View commit details
    Browse the repository at this point in the history

  4. Bump version to v7.0.1

    @aried3r
    aried3r committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    7ea4d91 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG.md

    @aried3r
    aried3r committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b5abcbd View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Implement proof of concept authorization

    @mirkode
    mirkode committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    74b4258 View commit details
    Browse the repository at this point in the history

  2. Fix logger error

    @mirkode
    mirkode committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    509dae4 View commit details
    Browse the repository at this point in the history

  3. Add some fields to AndroidNotification

    @mirkode
    mirkode committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    d8559d6 View commit details
    Browse the repository at this point in the history

  4. Remove notification node from message payload for FCM notifications 

    There is a type mismatch between message.notification and message.android.notification. The message.notification only accepts the attributes title, body, and image, whereas message.android.notification holds all the rest of the configuration. So in order to use message.notification along with message.android.notification there would be the need for an additional database field called something like android_configuration
    @mirkode
    mirkode committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    8f3cacf View commit details
    Browse the repository at this point in the history

  5. Fix notification handling in fcm/notification.rb 

    See https://github.com/rpush/rpush/pull/620\#discussion_r710926868 for further information
    @mirkode
    mirkode committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    0279be2 View commit details
    Browse the repository at this point in the history

  6. Add comment to necessary_data_exists? method

    @mirkode
    mirkode committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    9e083a9 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Stop auto-closing issues 

    Not the same, but similar rationale to what Rails did recently: rails/rails@acf4816
    @aried3r
    aried3r authored May 23, 2022
    Configuration menu
    Copy the full SHA
    e55243d View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Bump rack from 2.2.3 to 2.2.3.1 (rpush#638)

    @dependabot
    dependabot[bot] authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    16f9043 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Bump rails-html-sanitizer from 1.4.2 to 1.4.3 (rpush#642)

    @dependabot
    dependabot[bot] authored Aug 15, 2022
    Configuration menu
    Copy the full SHA
    eb48a90 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Merge branch 'master' into fcm-support-v2 

    * master:
  Bump rails-html-sanitizer from 1.4.2 to 1.4.3 (rpush#642)
  Bump rack from 2.2.3 to 2.2.3.1 (rpush#638)
  Stop auto-closing issues
    @AnilRh
    AnilRh committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b3cb24b View commit details
    Browse the repository at this point in the history

  2. Fix - missing gcm interface

    @AnilRh
    AnilRh committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    20a3fe4 View commit details
    Browse the repository at this point in the history

  3. fix code formatting - no change

    @AnilRh
    AnilRh committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    2f467bd View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Payload Data Size is now calculated based off the message data attribute 

    Priority value is now using 'normal' or 'high' instead of numeric values
Dry Run option is not implemented so throws an exception
Mutable Content is not implemented so throws an exception
    @AnilRh
    AnilRh committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8f662c2 View commit details
    Browse the repository at this point in the history

  2. Adding tests

    @AnilRh
    AnilRh committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3043dd7 View commit details
    Browse the repository at this point in the history

  3. Removing debug line

    @AnilRh
    AnilRh committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0b18e5b View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Adding debug line requested in PR rpush#620 

    Get tests working without all the ENV variables
    @AnilRh
    AnilRh committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    fb5d567 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Add properties to FCM App to allow operation without env vars

    @nigimaxx
    nigimaxx committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    39040cb View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from nigimaxx/fcm-support-v2 

    Add properties to FCM App to allow operation without env vars
    @AnilRh
    AnilRh authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    6a9e199 View commit details
    Browse the repository at this point in the history

  3. Adding new attributes to redis model

    @AnilRh
    AnilRh committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    576b336 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Adding 7.1 migration to active record tests. Updating Gemfile.lock

    @AnilRh
    AnilRh committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    99b33af View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. FCM returning error when data is sent in Android payload

    @AnilRh
    AnilRh committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6498354 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Moving notification keys to the correct location - only supporting An… 

    …droid
    @AnilRh
    AnilRh committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a5eccd6 View commit details
    Browse the repository at this point in the history

  2. As the FCM code moves around notification keys, it would be good to h… 

    …andle both stirng and symbol keys.
    @AnilRh
    AnilRh committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    4429f85 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. - Calling hook fcm_invalid_device_token if we get an invalid token re… 

    …sponse from FCM

- Adding specs for FCM daemon
- Clarifying error message
    @AnilRh
    AnilRh committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    fd260e5 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Adding a google credential cache

    @AnilRh
    AnilRh committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3fdf3ca View commit details
    Browse the repository at this point in the history

  2. Fixing Logging

    @AnilRh
    AnilRh committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    06aa50e View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Adding a google credential cache

    @AnilRh
    AnilRh committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    ccecae3 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Remove content_available from FCM implementation. It doesn't appear t… 

    …o be suported in Android
    @AnilRh
    AnilRh committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    4ab0185 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Merge pull request rpush#660 from AnilRh/fcm-support-v2

    @aried3r
    aried3r authored Jun 22, 2024
    Configuration menu
    Copy the full SHA
    5d576f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Allow all of the CI matrix to run, even on failure

    @aried3r
    aried3r authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a3cb803 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Use ActiveRecord to fetch Apps instead of Redis.

    @kirbycool
    Alex Katkova authored and kirbycool committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4886f40 View commit details
    Browse the repository at this point in the history

  2. TA-28669. Stop saving all rpush IDs to set.

    @kirbycool
    Alex Katkova authored and kirbycool committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e2ddafa View commit details
    Browse the repository at this point in the history

  3. TA-28669. Stop saving all rpush feedback IDs to set.

    @kirbycool
    Alex Katkova authored and kirbycool committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4b0cb4e View commit details
    Browse the repository at this point in the history

  4. Add temp logging to debug SSL error.

    @kirbycool
    Alex Katkova authored and kirbycool committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    fb21155 View commit details
    Browse the repository at this point in the history

  5. BUGS-1850. Retry after Errno::ECONNRESET

    @yanithx @kirbycool
    yanithx authored and kirbycool committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3592d72 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Allow Rails 5.1

    @kirbycool
    kirbycool committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    fb6cace View commit details
    Browse the repository at this point in the history

  2. Allow Rails 5.1

    @kirbycool
    kirbycool committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    3038055 View commit details
    Browse the repository at this point in the history