Use candlepin::repo in testing with a version fact

.github/workflows/ci.yml

@@ -6,16 +6,95 @@ on:
   schedule:
     - cron: '4 4 * * *'
 
+jobs:
+  setup_matrix:
+    if: github.event_name != 'schedule' || github.repository_owner == 'theforeman'
+    name: 'Setup Test Matrix'
+    runs-on: ubuntu-latest
+    outputs:
+      beaker_setfiles: ${{ steps.get_outputs.outputs.beaker_setfiles }}
+      puppet_major_versions: ${{ steps.get_outputs.outputs.puppet_major_versions }}
+      puppet_unit_test_matrix: ${{ steps.get_outputs.outputs.puppet_unit_test_matrix }}
+    env:
+      BUNDLE_WITHOUT: development:system_tests:release
+      PUPPET_GEM_VERSION: '~> 7.24'
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '2.7'
+          bundler-cache: true
+      - name: Run rake check
+        run: bundle exec rake check
+      - name: Run rake validate
+        run: bundle exec rake validate
+      - name: Run rake lint
+        run: bundle exec rake lint
+      - name: Setup Test Matrix
+        id: get_outputs
+        run: bundle exec metadata2gha --use-fqdn --pidfile-workaround false
 
-concurrency:
-  group: ${{ github.ref_name }}
-  cancel-in-progress: true
+  unit:
+    needs: setup_matrix
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include: ${{fromJson(needs.setup_matrix.outputs.puppet_unit_test_matrix)}}
+    env:
+      BUNDLE_WITHOUT: development:system_tests:release
+      PUPPET_GEM_VERSION: "~> ${{ matrix.puppet }}.24"
+    name: Unit / Puppet ${{ matrix.puppet }} (Ruby ${{ matrix.ruby }})
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+          cache-version: '1'
+      - name: Run tests
+        run: bundle exec rake parallel_spec
 
-jobs:
-  puppet:
-    name: Puppet
-    uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v1
-    with:
-      pidfile_workaround: 'false'
-      rubocop: false
-      cache-version: '1'
+  acceptance:
+    needs: setup_matrix
+    runs-on: ubuntu-latest
+    env:
+      BUNDLE_WITHOUT: development:test:release
+      PUPPET_GEM_VERSION: '~> 7.24'
+    strategy:
+      fail-fast: false
+      matrix:
+        setfile: ${{fromJson(needs.setup_matrix.outputs.beaker_setfiles)}}
+        puppet: ${{fromJson(needs.setup_matrix.outputs.puppet_major_versions)}}
+        candlepin_version:
+          - 'nightly'
+          - '4.10'
+    name: Acceptance / ${{ matrix.puppet.name }} - ${{ matrix.setfile.name }} - Candlepin ${{ matrix.candlepin_version }}
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '2.7'
+          bundler-cache: true
+          cache-version: '1'
+      - name: Run tests
+        run: bundle exec rake beaker
+        env:
+          BEAKER_PUPPET_COLLECTION: ${{ matrix.puppet.collection }}
+          BEAKER_setfile: ${{ matrix.setfile.value }}
+          # In Puppet 7 the locale ends up being C.UTF-8 if it isn't passed.
+          # This locale doesn't exist in EL7 and won't be supported either.
+          LANG: en_US.UTF-8
+          BEAKER_FACTER_CANDLEPIN_VERSION: ${{ matrix.candlepin_version }}
+
+  tests:
+    needs:
+      - unit
+      - acceptance
+    runs-on: ubuntu-latest
+    name: Test suite
+    steps:
+      - run: echo Test suite completed

spec/setup_acceptance_node.pp

@@ -4,6 +4,10 @@
   ensure => installed,
 }
 
+class { 'candlepin::repo':
+  version => pick(fact('candlepin_version'), 'nightly'),
+}
+
 if $facts['os']['selinux']['enabled'] {
   # Workaround for https://github.com/theforeman/puppet-candlepin/issues/188
   package { 'pki-core':
@@ -15,15 +19,6 @@
   }
 }
 
-# Defaults to staging, for release, use
-# $baseurl = "https://yum.theforeman.org/katello/nightly/candlepin/el${major}/x86_64/"
-$baseurl = "http://koji.katello.org/releases/yum/katello-nightly/candlepin/el${major}/x86_64/"
-
-yumrepo { 'candlepin':
-  baseurl  => $baseurl,
-  gpgcheck => 0,
-}
-
 # Needed as a workaround for idempotency
 if $facts['os']['selinux']['enabled'] {
   package { 'candlepin-selinux':