Use release repos in acceptance tests #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
reviewed
Oct 12, 2023
spec/setup_acceptance_node.pp
Outdated
| @@ -4,6 +4,10 @@ | |||
| ensure => installed, | |||
| } | |||
|
|
|||
| class { 'candlepin::repo': | |||
| version => pick(fact('candlepin_version', 'nightly')), | |||
There was a problem hiding this comment.
Suggested change
| version => pick(fact('candlepin_version', 'nightly')), | |
| version => pick(fact('candlepin_version') 'nightly'), |
This uses the candlepin::repo class we already have to use release repositories, rather than staging. It also tries to look for a `candlepin_version` fact, which can be used to test on other versions of Katello.
ekohl
force-pushed
the
use-stable-repo
branch
from
d4467fa to
8d3a3b0
Compare
ehelms
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the candlepin::repo class we already have to use release repositories, rather than staging.
It also tries to look for a
candlepin_versionfact, which can be used to test on other versions of Katello.This takes part of #244. The
BEAKER_FACTERpart should be ready with #241 & theforeman/foreman-installer-modulesync#152. It doesn't set a default for thecandlepin::repoclass, forcing users to choose a version. Instead it usespick()to fall back to nightly in CI.