Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding loading css class #7

Closed
wants to merge 1 commit into from
Closed

Conversation

thi3rry
Copy link

@thi3rry thi3rry commented Jul 6, 2014

For big image, intense do nothing during image loading.

Adding an css class to styling element while image loading

For big image, intense do nothing during image loading.

Adding an css class to styling element while image loading
@tholman
Copy link
Owner

tholman commented Jul 6, 2014

Hmm, this is definitely a bug, although I think this fix isn't quite the right fix. Will want to build a little spinner (something that is probably built with js & css animations, but still contained within intense.js), that goes off when the image is loading, and then reveal once its complete, with the image gracefully fading in.

Hopefully I can take a look this week, and see if your changes work well towards that!

@matth3wga0
Copy link

Do not build a spinner with intense.js, just provide the js event or the css class, there're lots of awesome spinner library such as spin.js.

You should build intense.js as a library not an application.

@tholman
Copy link
Owner

tholman commented Jul 7, 2014

Intense.js should be stand alone, and easy to use for anyone which I feel should involve a simple loader. Its not worth providing a semi-broken experience with "you need to use X and Y" to have it working as it should.

@jwebcat
Copy link

jwebcat commented Jul 8, 2014

I agree with @TimHolman a simple loader with a Callback on load will do perfectly in ~10 lines of js

@tholman tholman mentioned this pull request Jul 9, 2014
@tholman
Copy link
Owner

tholman commented Jul 9, 2014

Since this is a small part of #10, I'm merging it in, and closing this branch of the issue.

Thanks for the pull @thi3rry, will take your code into consideration for the fix!

@tholman tholman closed this Jul 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants