-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform search in separate thread and stream in results #40
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
dfef6bb
Use parallel walker
thomasschafer 7cda6ef
Fix issues with hanging on large dirs
thomasschafer 56ce080
Fix search results being marked as completed too early
thomasschafer 0db45d1
Move work off main thread
thomasschafer d74e0c5
Show result num in UI
thomasschafer a5b22a6
Fix unneeded rerenders
thomasschafer fffeade
(wip) cancel join handle
thomasschafer cf4e60b
(wip) continue to fix join handle
thomasschafer f5a1d73
Combine screen and state enums
thomasschafer d29ead2
Pass replacement state in channel
thomasschafer 3b4c9d5
Add background processing sender
thomasschafer 64d81ab
Fix slow scrolling with long lines
thomasschafer 80221c0
Don't replace in binary files
thomasschafer 57f72e8
Refactoring
thomasschafer 8f9a0e1
Refactor perform_search_if_valid
thomasschafer 240ced0
Fix and refactor app tests
thomasschafer 39cbef7
Fix remaining tests
thomasschafer 21a4376
Fix tests in CI
thomasschafer 85d14e6
Bump version
thomasschafer ad0dcd5
Update gif
thomasschafer 8869d86
Move rand to dev deps
thomasschafer dc86c18
Fix issue after rebasing
thomasschafer dbae897
Fix tests on windows
thomasschafer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "scooter" | ||
version = "0.1.2" | ||
version = "0.2.0" | ||
edition = "2021" | ||
authors = ["[email protected]"] | ||
license = "MIT" | ||
|
@@ -14,6 +14,7 @@ categories = ["command-line-utilities"] | |
[dependencies] | ||
anyhow = "1.0.86" | ||
clap = { version = "4.5.18", features = ["derive"] } | ||
content_inspector = "0.2.4" | ||
crossterm = { version = "0.27", features = ["event-stream"] } | ||
dirs = "5.0.1" | ||
etcetera = "0.8.0" | ||
|
@@ -31,6 +32,7 @@ tokio = { version = "1.40.0", features = ["full"] } | |
|
||
[dev-dependencies] | ||
tempfile = "3.12.0" | ||
rand = "0.8.5" | ||
|
||
[lib] | ||
name = "scooter" | ||
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[toolchain] | ||
channel = "nightly" # Allows us to use MappedLockGuard | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance of not using nightly channel? this would prevent brew from building the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out - fixed here