Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform search in separate thread and stream in results #40

Merged
merged 23 commits into from
Nov 30, 2024
Merged

Perform search in separate thread and stream in results #40

merged 23 commits into from
Nov 30, 2024

Conversation

thomasschafer
Copy link
Owner

@thomasschafer thomasschafer commented Nov 23, 2024 •
edited
Loading

This PR:

  • Performs the search in a separate thread, so that results can be streamed in immediately, showing interim results
  • Uses a parallel directory walker for improved performance
  • Adds the result number to the UI, to make it clear how far down the list of results the user is

Resolves #28
Resolves #29

@thomasschafer thomasschafer force-pushed the tschafer-use-parallel-walker branch 16 times, most recently from a011ce5 to f174fd3 Compare November 30, 2024 14:48
@thomasschafer thomasschafer changed the title Stream in results rather than blocking Perform search in separate thread and stream in results Nov 30, 2024
@thomasschafer thomasschafer mentioned this pull request Nov 30, 2024
Merged
@thomasschafer thomasschafer force-pushed the tschafer-use-parallel-walker branch 6 times, most recently from 42c2e44 to 2de5d52 Compare November 30, 2024 15:40
@thomasschafer thomasschafer marked this pull request as ready for review November 30, 2024 15:41
@thomasschafer thomasschafer force-pushed the tschafer-use-parallel-walker branch from 1e603c7 to b55377a Compare November 30, 2024 15:57
@thomasschafer thomasschafer force-pushed the tschafer-use-parallel-walker branch from b55377a to dbae897 Compare November 30, 2024 16:18
@thomasschafer thomasschafer merged commit cde73d4 into main Nov 30, 2024
3 checks passed
@thomasschafer thomasschafer deleted the tschafer-use-parallel-walker branch November 30, 2024 16:23
@chenrui333 chenrui333 mentioned this pull request Nov 30, 2024
Closed
chenrui333
chenrui333 reviewed Nov 30, 2024
View reviewed changes
rust-toolchain.toml
@@ -0,0 +1,2 @@
[toolchain]
channel = "nightly" # Allows us to use MappedLockGuard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance of not using nightly channel? this would prevent brew from building the release.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out - fixed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hotkeys don't work in "Performing search..." Consider showing interim results
2 participants
@thomasschafer @chenrui333