Hide invalid keys on replacement screen #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasschafer
force-pushed
the
tschafer-hide-invalid-keys-replacement-screen
branch
from
c5704d0 to
718cf31
Compare
thomasschafer
deleted the
tschafer-hide-invalid-keys-replacement-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because replacement is performed on the main thread, key presses are queued up and don't work immediately when a replacement is in progress. (I want to fix this and move replacement into a separate thread soon, like was done on the search screen in #40). As a workaround for now this PR removes the global key press hints from the replacement screen.