Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

word_wrap: fix Ruby 2.7 warning #1314

Merged
merged 1 commit into from
Aug 24, 2020
Merged

word_wrap: fix Ruby 2.7 warning #1314

merged 1 commit into from
Aug 24, 2020

Conversation

fatih
Copy link

@fatih fatih commented Jul 8, 2020

This fixes the following warning:

vendor/gems/ruby/2.7.0/gems/shoulda-matchers-4.3.0/lib/shoulda/matchers/util/word_wrap.rb:8: 
  warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

This fixes the following warning:

```
vendor/gems/ruby/2.7.0/gems/shoulda-matchers-4.3.0/lib/shoulda/matchers/util/word_wrap.rb:8: 
  warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
```
@mcmire
Copy link
Collaborator

mcmire commented Jul 9, 2020

Thanks for this! We're working on adding Ruby 2.7 to the test matrix (see #1310), so we'll make sure to merge this once that's merged in.

@fatih
Copy link
Author

fatih commented Jul 10, 2020

@mcmire thanks for the heads up. Let me know if there is anything else I need to do. I have a similar PR here in another shoulda- repo: thoughtbot/shoulda-context#64

@mcmire
Copy link
Collaborator

mcmire commented Aug 24, 2020

I've merged #1310, but the same issue that held up thoughtbot/shoulda-context#64 is also holding this one up too (the bit of code that detects for warnings and fails the build is also not working here). I am fixing this in #1328, so once that's merged then we should be clear to merge this.

@mcmire
Copy link
Collaborator

mcmire commented Aug 24, 2020

Actually based on my findings in #1328 I can already guarantee this will fix the warning so I'll go ahead and merge this ahead of that PR :) Thank you!

@mcmire mcmire merged commit ef82150 into thoughtbot:master Aug 24, 2020
@fatih
Copy link
Author

fatih commented Aug 24, 2020

Thank you @mcmire

@fatih fatih deleted the patch-1 branch August 24, 2020 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants