Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.4.0 #1324

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Release v4.4.0 #1324

merged 1 commit into from
Aug 26, 2020

Conversation

mcmire
Copy link
Collaborator

@mcmire mcmire commented Jul 25, 2020

Features

  • Add an ignoring_check_for_db_index qualifier to the have_secure_token
    matcher, since has_secure_token encourages use of an index but does not
    enforce it. (#1278)

  • Add allow_blank to validate_length_of to match other validation matchers.
    (#725, #1318)

  • Add new matcher have_implicit_order_column which can be used to test the
    implicit_order_column setting for ActiveRecord models under Rails 6+.
    (#1243)

  • Add a new is_other_than qualifier to validate_numericality_of to be able
    to test the numericality validation's :other_than option. (#1282)

  • Add a new have_one_attached and have_many_attached matchers for testing
    the new model-level ActiveStorage macros in Rails 6. (#1102)

Bug fixes

  • Fix performance of allow_value so that it doesn't hang if the given value is
    really long. (#1290)

  • Fix have_many so that it is possible to test an association that has a scope
    that takes an argument. (#952, #992)

  • Update validate_uniqueness_of to use the public validators_on instead of
    the private _validators when reading validations off of a model. This
    enables shoulda-matchers to be used with the schema_validations gem.
    (#995)

  • Update validate_uniqueness_of to work with scopes that are time columns.
    (#1190)

  • Fix have_and_belong_to_many so that when using the join_table qualifier
    you can pass a symbol rather than a string. (#1323)

Improvements

  • Update have_many when used against a :through association so that it fails
    if the inverse model does not have a belongs_to association. (#646,
    #723, c0a1578)

  • Add Ruby 2.7 to test matrix and default development Ruby. (#1310)

  • Remove warnings emitted on Ruby 2.7 in word_wrap. (#1314)

  • Remove warnings emitted on Ruby 2.7 in Doublespeak. (#1328)

  • Clean up requires within the code by converting them to autoloads. (#1320)

@mcmire
Copy link
Collaborator Author

mcmire commented Jul 25, 2020

@guialbuk Looks like it's been a while since the last release and I feel like we ought to release a new version. I'm shooting to also include #1323, but is there anything else we want to include in here?

@mcmire
Copy link
Collaborator Author

mcmire commented Jul 25, 2020

Or @composerinteralia since you've been commenting lately! ^

@composerinteralia
Copy link

composerinteralia commented Jul 27, 2020

It would be great to get #1314 out soon, since Ruby 2.7 deprecation warnings coming from gems are still preventing a lot of folks from upgrading, but if 4.4.0 is ready let's go ahead and release it and we can send out a patch release for the Ruby 2.7 fix when it is ready.

It is probably worth following up shortly after the 4.4.0 release with a 5.0.0 release that drops support for old Ruby versions and Rails 4.2. That will make it easier for us to merge #1310, which is what is currently blocking #1314.

I can take on some of the release work if that would be helpful.

@mcmire
Copy link
Collaborator Author

mcmire commented Aug 24, 2020

#1323, #1310, and #1314 are now merged. Everyone good with this release?

@mcmire mcmire force-pushed the release/v4.4.0 branch 2 times, most recently from 486e17e to 454337f Compare August 26, 2020 02:14
@mcmire mcmire merged commit c8cd836 into master Aug 26, 2020
@mcmire mcmire deleted the release/v4.4.0 branch August 26, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants