Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deleted deprecated packages #202

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Oct 9, 2024

Description

These packages were causing problems and misunderstandings, so this PR removes them.
If someone needs them and wants to maintain them, they can be brought back

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@knzo25 knzo25 requested a review from yabuta October 9, 2024 04:26
@knzo25 knzo25 self-assigned this Oct 9, 2024
@knzo25
Copy link
Collaborator Author

knzo25 commented Oct 15, 2024

@yabuta
Unless there are any objection, I will be just merging this in about a week

Copy link
Collaborator

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knzo25 knzo25 merged commit 84b1ab6 into tier4/universe Oct 16, 2024
7 checks passed
@knzo25 knzo25 deleted the chore/remove_deprecated_nodes branch October 16, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants