fix(pre-commit): add flake8-ros #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asa-naki
approved these changes
May 13, 2024
asa-naki
pushed a commit
that referenced
this pull request
Aug 27, 2024
* update pre-commit-config * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
@Mergifyio backport beta/v0.3.17.1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
* update pre-commit-config * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 751ad2b)
4 tasks
asa-naki
pushed a commit
that referenced
this pull request
Aug 29, 2024
fix(pre-commit): add flake8-ros (#1291) * update pre-commit-config * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 751ad2b) Co-authored-by: Shigekazu Fukuta <[email protected]>
|
@Mergifyio backport beta/v0.3.18.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
* update pre-commit-config * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 751ad2b)
4 tasks
asa-naki
pushed a commit
that referenced
this pull request
Aug 29, 2024
fix(pre-commit): add flake8-ros (#1291) * update pre-commit-config * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 751ad2b) Co-authored-by: Shigekazu Fukuta <[email protected]>
|
@Mergifyio backport beta/v0.3.16.1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
* update pre-commit-config * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 751ad2b)
4 tasks
asa-naki
pushed a commit
that referenced
this pull request
Aug 29, 2024
fix(pre-commit): add flake8-ros (#1291) * update pre-commit-config * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 751ad2b) Co-authored-by: Shigekazu Fukuta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pre-commit.ciがflake8が、failする問題を解決するPRとなります。
falke8のバージョンが、v4.0.1の場合に以下のクラッシュログが出力されています。
https://results.pre-commit.ci/run/github/438106587/1715588946.TJlGL3TmRU2aARzW8KpB2Q
autoware.universeのv4.0.1のため、autoware_launch.x1.eveよりバージョンが古いため、
flakeのバージョンが古いことが原因と判断しています。
対策方針：
対策方法：
※以下の対策は、autoware_launch.x1.eveと同一で、実績のある実装となります。
1.flake8のv6.0.0が利用するための修正
https://github.com/tier4/pre-commit-hooks-ros/blob/6dff55599550b23f878faea477b8950bde2bfb7c/.pre-commit-hooks.yaml#L2-L20
2.不要なflake8の既存実装を削除
影響のあるCI
全てフォーマッターにあたるため更新にようる実装への影響はない。
Tests performed
pre-commit.ciがpassする事を確認済み
https://results.pre-commit.ci/run/github/438106587/1715598146.hX5oIshYRT2lKSQdPEDIkA
Effects on system behavior
特にありません
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.