forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(motion_velocity_smoother): force slow driving #1409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Go Sakayori <[email protected]>
Signed-off-by: Go Sakayori <[email protected]>
Signed-off-by: Go Sakayori <[email protected]>
go-sakayori
requested review from
rej55,
mkuri,
satoshi-ota and
TakaHoribe
as code owners
July 11, 2024 03:57
shmpwk
approved these changes
Jul 11, 2024
shmpwk
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
go-sakayori
added a commit
that referenced
this pull request
Aug 6, 2024
* add force slow driving function Signed-off-by: Go Sakayori <[email protected]> * fix state Signed-off-by: Go Sakayori <[email protected]> * erase log info Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]>
go-sakayori
added a commit
that referenced
this pull request
Aug 7, 2024
* add force slow driving function Signed-off-by: Go Sakayori <[email protected]> * fix state Signed-off-by: Go Sakayori <[email protected]> * erase log info Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]>
go-sakayori
added a commit
that referenced
this pull request
Dec 6, 2024
* add force slow driving function Signed-off-by: Go Sakayori <[email protected]> * fix state Signed-off-by: Go Sakayori <[email protected]> * erase log info Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]>
rej55
pushed a commit
that referenced
this pull request
Dec 13, 2024
* add force slow driving function Signed-off-by: Go Sakayori <[email protected]> * fix state Signed-off-by: Go Sakayori <[email protected]> * erase log info Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a force slow driving function to the motion_velocity_smoother node. The function is activated when there is a trigger from the FOA. It can only be activated when the ego velocity is lower than the threshold.
ex. Use when start/goal planner is stuck
Related links
launch
How was this PR tested?
Vehicle experiment + PSim
Notes for reviewers
This is a temporary function.
Interface changes
None.
Effects on system behavior
None.