Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(virtual traffic light): suppress lauch (#1290) #1537

Closed

Conversation

kimurariku
Copy link

@kimurariku kimurariku commented Sep 12, 2024

このコミットからcherry-pick


Description

beta/v0.3.18.1で取り込まれた #1290 を再度beta/v0.3.19に適用する
このPRでは走行中に、End Line通過済みのVTLが反応して、Stop Lineが表示される事がある課題を解決するため、
通過し終わったVTLに対して、同じVTLが再度起動しないようにする修正する。

Related links

#1290

Parent Issue:

  • Link

How was this PR tested?

git diff beta/v0.3.18.1 fix/virtual_traffic_light/suppress_launch planning/behavior_velocity_planner/src/scene_module/virtual_traffic_light/manager.cpp を実行して #1290 の取り込みと差分がないことを確認しました。

特定の状況下における不具合修正のPRであり、妥当性については #1290 において確認されています。

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

* suppress launch

Signed-off-by: Yuki Takagi <[email protected]>

* add existence check

Signed-off-by: Yuki Takagi <[email protected]>

---------

Signed-off-by: Yuki Takagi <[email protected]>
Co-authored-by: Shigekazu Fukuta <[email protected]>
@kimurariku
Copy link
Author

@Mergifyio backport fix/virtual_traffic_light/suppress_launch

Copy link

mergify bot commented Sep 12, 2024

backport fix/virtual_traffic_light/suppress_launch

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

Copy link

@kimurariku kimurariku requested a review from asa-naki September 12, 2024 09:27
@asa-naki asa-naki closed this Sep 19, 2024
@rej55 rej55 deleted the fix/virtual_traffic_light/suppress_launch branch December 25, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants