Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detection_area)!: suppression of giving up stopping #1631

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

yuki-takagi-66
Copy link

@yuki-takagi-66 yuki-takagi-66 commented Nov 8, 2024

Description

This PR implements functionality to enable stopping when obstacles are detected within the DA (Detection Area) after passing the stop line.

The implemented code leverages existing features from autowarefoundation to meet the requirements specified in the documentation.

This PR is implemented with reference to the following PRs:

Implementation Details

The correspondence between design requirements and implementation is as follows:

Requirement Implementation Location
Add Param for margin in StopLine override judgment https://github.com/tier4/autoware.universe/pull/1631/files#diff-eab2555cc9571b6c90cacb8122131e12d7bd9258aaf241781c4e7cf3287b7b73R61
Add Param for DA judgment time extension setting https://github.com/tier4/autoware.universe/pull/1631/files#diff-eab2555cc9571b6c90cacb8122131e12d7bd9258aaf241781c4e7cf3287b7b73R62
When DA judgment time extension is enabled, extend DA stop judgment time until (vehicle speed > 0) is observed https://github.com/tier4/autoware.universe/pull/1631/files#diff-45a0b8c1f68a13b18e90d3b03a96d5572006228360e908ee749b333fa7acb7e5R234-R238
Add margin to StopLine override judgment https://github.com/tier4/autoware.universe/pull/1631/files#diff-45a0b8c1f68a13b18e90d3b03a96d5572006228360e908ee749b333fa7acb7e5R374-R375

Related links

Parent Issue:

How was this PR tested?

Since there are no changes to the Interface*, we determined that functional testing of this DetectionAreaModule using the following Test criteria is sufficient:

I confirm that the specified tests have passed and no critical defects were found in the specified design.

*) Topic names, Msg definitions, SceneModuleInterface

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@peeeechi peeeechi requested review from yn-mrse and peeeechi November 15, 2024 02:56
@peeeechi
Copy link

Please add the following to 'How was this PR tested?' section
(This is to ensure that test perspectives and results can be tracked in the commit):

@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review November 15, 2024 04:07
Copy link

@yn-mrse yn-mrse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuki-takagi-66
Please change the base branch from beta/v0.3.19 to beta/v0.3.20.

Copy link

@yn-mrse yn-mrse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link your internal JIRA managed tickets to maintain traceability.

Copy link

@yn-mrse yn-mrse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is difficult to understand what specific changes are being referred to by "sync latest feature", please set a PR title that mentions the specific feature.

Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 force-pushed the feat/bv0_3_19+detection_area branch from db407e1 to b7f9c8c Compare November 15, 2024 06:29
@yuki-takagi-66 yuki-takagi-66 changed the base branch from beta/v0.3.19 to beta/v0.3.20 November 15, 2024 06:29
@yn-mrse
Copy link

yn-mrse commented Nov 15, 2024

@yuki-takagi-66
image

The basic design document clearly states that "please consider the detailed design," but this PR makes no mention of the detailed design.
Could you attach the detailed design to the PR?

Or, if you have decided that implementing it as per the basic design document is fine, please state that in the Description field.

Copy link

sonarcloud bot commented Nov 15, 2024

@yn-mrse
Copy link

yn-mrse commented Nov 15, 2024

Please justify all changes in the PR (show that the changes are necessary and sufficient).

In the "Description" field, clearly list the features and clarify how they correspond to the implementation.

@yn-mrse
Copy link

yn-mrse commented Nov 15, 2024

In the "How was this PR tested?" field, please include not only the URL, but also a summary of the results and your judgement as the PR submitter as to whether the changes to this PR are appropriate.

@yuki-takagi-66 yuki-takagi-66 changed the title feat(detection_area)!: sync latest feature feat(detection_area)!: Suppression of giving up stopping Nov 18, 2024
Copy link

@peeeechi peeeechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peeeechi peeeechi self-requested a review November 20, 2024 05:57
@yuki-takagi-66 yuki-takagi-66 changed the title feat(detection_area)!: Suppression of giving up stopping feat(detection_area)!: suppression of giving up stopping Nov 21, 2024
Copy link

@peeeechi peeeechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peeeechi peeeechi merged commit 2df52bb into beta/v0.3.20 Nov 22, 2024
14 of 23 checks passed
@peeeechi peeeechi deleted the feat/bv0_3_19+detection_area branch November 22, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants