feat(mrm_handler): mrm recoverable option (#1316) #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
* implement is_mrm_recoverable option of mrm_handler * add pull over after stopped option * update json schema of mrm_handler Signed-off-by: Tomohito Ando <[email protected]>
* implement service for clear MRM behavior * clang format Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
force-pushed
the
feat/add-mrm-recoverable-feature
branch
from
babdfaa to
2aca1c9
Compare
Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
requested review from
mkuri,
veqcc,
TetsuKawa,
isamu-takagi and
ito-san
as code owners
kotaro-hihara
approved these changes
Nov 22, 2024
TetsuKawa
pushed a commit
that referenced
this pull request
Dec 1, 2024
* feat(mrm_handler): mrm recoverable option (#1316) * implement is_mrm_recoverable option of mrm_handler * add pull over after stopped option * update json schema of mrm_handler Signed-off-by: Tomohito Ando <[email protected]> * feat: implement service for clear MRM behavior (#1511) * implement service for clear MRM behavior * clang format Signed-off-by: Tomohito Ando <[email protected]> * feat: implement MRM automatic recovery feature Signed-off-by: Tomohito Ando <[email protected]> * fix typo Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: Shohei Sakai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update for launcher: https://github.com/tier4/autoware_launch.x2/pull/847
このPRでは、MRMからの自動復帰を選択するための機能を取り込んでいます。
具体的には、以下の変更を取り込んでいます。
Related links
Related JIRA: https://tier4.atlassian.net/browse/RT0-34249
How was this PR tested?
詳細は下記を確認ください。
TIER IV INTERNAL
PSimで以下を確認しています。
simplescreenrecorder-2024-11-22_19.47.56.mp4
Notes for reviewers
Warning
MOT側でMRMを解除するボタンの実装はまだ取り込まれていません。
復帰不可なMRMが発生した場合でも、ターミナルで下記サービスを実行すれば解除できます。
Interface changes
None.
Effects on system behavior
None.