Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(perception): rearrange clustering pipeline (#4999) #848

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

miursh
Copy link

@miursh miursh commented Sep 19, 2023

Description

Cherry-pick

Related links

https://github.com/tier4/autoware_launch.xx1/pull/638

Tests performed

See original autowarefoundation#4999

tested by logging_simulator.launch.xml
image

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…on#4999)

* fix: change downsample filter

Signed-off-by: badai-nguyen <[email protected]>

* fix: remove downsamle after compare map

Signed-off-by: badai-nguyen <[email protected]>

* fix: add low range cropbox

Signed-off-by: badai-nguyen <[email protected]>

* refactor: use_pointcloud_map

Signed-off-by: badai-nguyen <[email protected]>

* chore: refactor

Signed-off-by: badai-nguyen <[email protected]>

* fix: add roi based clustering option

Signed-off-by: badai-nguyen <[email protected]>

* chore: change node name

Signed-off-by: badai-nguyen <[email protected]>

* fix: launch argument pasrer

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Copy link

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 59051ee into tmp/beta/v0.10.1 Sep 19, 2023
@miursh miursh deleted the feat/rearrange_clustering_pipeline branch September 19, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants