Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add package name prefix of autoware_ for detected_object_feature_remover #21

Conversation

badai-nguyen
Copy link

@badai-nguyen badai-nguyen commented Jul 22, 2024

Description

This PR adds the autoware_ prefix to the package name.
Related to PR: autowarefoundation/autoware.universe#8127

Changes are as following.

  1. Package names in package.xml
  2. Launch files $(find-pkg-share ...)

This PR do not contains any logic change.

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@badai-nguyen badai-nguyen requested review from manato, aohsato and technolojin and removed request for manato July 22, 2024 11:17
@badai-nguyen badai-nguyen marked this pull request as ready for review July 22, 2024 11:17
@badai-nguyen badai-nguyen requested a review from YoshiRi July 23, 2024 02:26
Copy link

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit cf67c89 into tier4:refactor/autoware-prefix Jul 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants