chore: add missing includes reported by the new, stricter include-wha…

…t-you-use rule Signed-off-by: Max SCHMELLER <[email protected]>
tier4 · Feb 3, 2025 · 427d031 · 427d031
1 parent 7be8d0f
commit 427d031
Show file tree

Hide file tree

Showing 52 changed files with 182 additions and 3 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -89,7 +89,7 @@ repos:
       - id: cpplint
         # runtime/arrays uses the name of the variable to determine const-ness.
         # This does not play well with our naming conventions
-        args: [--quiet, --filter=-runtime/arrays]
+        args: [--quiet, '--filter=-runtime/arrays,-build/c++17,-readability/casting']
         exclude: .cu
 
 exclude: .svg
diff --git a/nebula_common/src/velodyne/velodyne_calibration_decoder.cpp b/nebula_common/src/velodyne/velodyne_calibration_decoder.cpp
@@ -10,6 +10,10 @@
 
 #include <fstream>
 #include <iostream>
+#include <limits>
+#include <map>
+#include <string>
+#include <utility>
 
 #ifdef HAVE_NEW_YAMLCPP
 namespace YAML

diff --git a/nebula_decoders/src/nebula_decoders_continental/decoders/continental_ars548_decoder.cpp b/nebula_decoders/src/nebula_decoders_continental/decoders/continental_ars548_decoder.cpp
@@ -17,7 +17,10 @@
 #include <nebula_common/continental/continental_ars548.hpp>
 
 #include <cmath>
+#include <memory>
+#include <string>
 #include <utility>
+#include <vector>
 
 namespace nebula::drivers::continental_ars548
 {

diff --git a/nebula_decoders/src/nebula_decoders_continental/decoders/continental_srr520_decoder.cpp b/nebula_decoders/src/nebula_decoders_continental/decoders/continental_srr520_decoder.cpp
@@ -20,7 +20,11 @@
 #include <boost/algorithm/string/join.hpp>
 
 #include <cmath>
+#include <iostream>
+#include <memory>
+#include <string>
 #include <utility>
+#include <vector>
 
 namespace nebula::drivers::continental_srr520
 {

diff --git a/nebula_decoders/src/nebula_decoders_hesai/hesai_driver.cpp b/nebula_decoders/src/nebula_decoders_hesai/hesai_driver.cpp
@@ -13,6 +13,10 @@
 #include "nebula_decoders/nebula_decoders_hesai/decoders/pandar_xt32.hpp"
 #include "nebula_decoders/nebula_decoders_hesai/decoders/pandar_xt32m.hpp"
 
+#include <memory>
+#include <tuple>
+#include <vector>
+
 // #define WITH_DEBUG_STD_COUT_HESAI_CLIENT // Use std::cout messages for debugging
 
 namespace nebula::drivers

diff --git a/nebula_decoders/src/nebula_decoders_robosense/robosense_driver.cpp b/nebula_decoders/src/nebula_decoders_robosense/robosense_driver.cpp
@@ -7,6 +7,10 @@
 #include "nebula_decoders/nebula_decoders_robosense/decoders/helios.hpp"
 #include "nebula_decoders/nebula_decoders_robosense/decoders/robosense_decoder.hpp"
 
+#include <memory>
+#include <tuple>
+#include <vector>
+
 namespace nebula::drivers
 {
 

diff --git a/nebula_decoders/src/nebula_decoders_robosense/robosense_info_driver.cpp b/nebula_decoders/src/nebula_decoders_robosense/robosense_info_driver.cpp
@@ -7,6 +7,11 @@
 #include "nebula_decoders/nebula_decoders_robosense/decoders/helios.hpp"
 #include "nebula_decoders/nebula_decoders_robosense/decoders/robosense_info_decoder.hpp"
 
+#include <map>
+#include <memory>
+#include <string>
+#include <vector>
+
 namespace nebula::drivers
 {
 

diff --git a/nebula_decoders/src/nebula_decoders_velodyne/decoders/vlp16_decoder.cpp b/nebula_decoders/src/nebula_decoders_velodyne/decoders/vlp16_decoder.cpp
@@ -5,7 +5,10 @@
 #include <angles/angles.h>
 
 #include <cmath>
+#include <memory>
+#include <tuple>
 #include <utility>
+#include <vector>
 
 namespace nebula
 {

diff --git a/nebula_decoders/src/nebula_decoders_velodyne/decoders/vlp32_decoder.cpp b/nebula_decoders/src/nebula_decoders_velodyne/decoders/vlp32_decoder.cpp
@@ -5,7 +5,10 @@
 #include <angles/angles.h>
 
 #include <cmath>
+#include <memory>
+#include <tuple>
 #include <utility>
+#include <vector>
 
 namespace nebula
 {

diff --git a/nebula_decoders/src/nebula_decoders_velodyne/decoders/vls128_decoder.cpp b/nebula_decoders/src/nebula_decoders_velodyne/decoders/vls128_decoder.cpp
@@ -5,7 +5,10 @@
 #include <angles/angles.h>
 
 #include <cmath>
+#include <memory>
+#include <tuple>
 #include <utility>
+#include <vector>
 
 namespace nebula
 {

diff --git a/nebula_decoders/src/nebula_decoders_velodyne/velodyne_driver.cpp b/nebula_decoders/src/nebula_decoders_velodyne/velodyne_driver.cpp
@@ -6,6 +6,10 @@
 #include "nebula_decoders/nebula_decoders_velodyne/decoders/vlp32_decoder.hpp"
 #include "nebula_decoders/nebula_decoders_velodyne/decoders/vls128_decoder.hpp"
 
+#include <memory>
+#include <tuple>
+#include <vector>
+
 namespace nebula::drivers
 {
 VelodyneDriver::VelodyneDriver(

diff --git a/nebula_examples/src/hesai/hesai_ros_offline_extract_bag_pcd.cpp b/nebula_examples/src/hesai/hesai_ros_offline_extract_bag_pcd.cpp
@@ -26,7 +26,11 @@
 
 #include <pcl_conversions/pcl_conversions.h>
 
+#include <iostream>
+#include <memory>
 #include <regex>
+#include <string>
+#include <vector>
 
 namespace nebula::ros
 {

diff --git a/nebula_examples/src/hesai/hesai_ros_offline_extract_bag_pcd_main.cpp b/nebula_examples/src/hesai/hesai_ros_offline_extract_bag_pcd_main.cpp
@@ -16,7 +16,9 @@
 
 #include <rclcpp/rclcpp.hpp>
 
+#include <cstdio>
 #include <memory>
+#include <string>
 
 int main(int argc, char * argv[])
 {

diff --git a/nebula_examples/src/hesai/hesai_ros_offline_extract_pcd.cpp b/nebula_examples/src/hesai/hesai_ros_offline_extract_pcd.cpp
@@ -22,10 +22,12 @@
 #include "rosbag2_storage/storage_options.hpp"
 
 #include <nebula_common/hesai/hesai_common.hpp>
-// #include <boost/filesystem/path.hpp>
-// #include <boost/filesystem/operations.hpp>
 
+#include <iostream>
+#include <memory>
 #include <regex>
+#include <string>
+#include <vector>
 
 namespace nebula::ros
 {

diff --git a/nebula_examples/src/hesai/hesai_ros_offline_extract_pcd_main.cpp b/nebula_examples/src/hesai/hesai_ros_offline_extract_pcd_main.cpp
@@ -16,7 +16,9 @@
 
 #include <rclcpp/rclcpp.hpp>
 
+#include <cstdio>
 #include <memory>
+#include <string>
 
 int main(int argc, char * argv[])
 {

diff --git a/nebula_examples/src/velodyne/velodyne_ros_offline_extract_bag_pcd.cpp b/nebula_examples/src/velodyne/velodyne_ros_offline_extract_bag_pcd.cpp
@@ -18,7 +18,11 @@
 #include <rosbag2_cpp/writers/sequential_writer.hpp>
 
 #include <cmath>
+#include <iostream>
+#include <memory>
 #include <regex>
+#include <string>
+#include <vector>
 
 namespace nebula::ros
 {

diff --git a/nebula_examples/src/velodyne/velodyne_ros_offline_extract_bag_pcd_main.cpp b/nebula_examples/src/velodyne/velodyne_ros_offline_extract_bag_pcd_main.cpp
@@ -16,7 +16,9 @@
 
 #include <rclcpp/rclcpp.hpp>
 
+#include <cstdio>
 #include <memory>
+#include <string>
 
 int main(int argc, char * argv[])
 {

diff --git a/...la_hw_interfaces/src/nebula_continental_hw_interfaces/continental_ars548_hw_interface.cpp b/...la_hw_interfaces/src/nebula_continental_hw_interfaces/continental_ars548_hw_interface.cpp
@@ -17,6 +17,12 @@
 
 #include <nebula_common/continental/continental_ars548.hpp>
 
+#include <iostream>
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 namespace nebula::drivers::continental_ars548
 {
 ContinentalARS548HwInterface::ContinentalARS548HwInterface()

diff --git a/...la_hw_interfaces/src/nebula_continental_hw_interfaces/continental_srr520_hw_interface.cpp b/...la_hw_interfaces/src/nebula_continental_hw_interfaces/continental_srr520_hw_interface.cpp
@@ -18,8 +18,12 @@
 #include <nebula_common/continental/continental_srr520.hpp>
 #include <nebula_common/continental/crc.hpp>
 
+#include <iostream>
 #include <limits>
+#include <memory>
 #include <sstream>
+#include <string>
+#include <utility>
 
 namespace nebula::drivers::continental_srr520
 {

diff --git a/nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp b/nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp
@@ -15,10 +15,13 @@
 #include <boost/asio/socket_base.hpp>
 
 #include <cassert>
+#include <iostream>
+#include <memory>
 #include <sstream>
 #include <stdexcept>
 #include <string>
 #include <thread>
+#include <vector>
 
 // #define WITH_DEBUG_STDOUT_HESAI_HW_INTERFACE
 

diff --git a/nebula_hw_interfaces/src/nebula_robosense_hw_interfaces/robosense_hw_interface.cpp b/nebula_hw_interfaces/src/nebula_robosense_hw_interfaces/robosense_hw_interface.cpp
@@ -1,6 +1,11 @@
 // Copyright 2024 TIER IV, Inc.
 
 #include "nebula_hw_interfaces/nebula_hw_interfaces_robosense/robosense_hw_interface.hpp"
+
+#include <iostream>
+#include <memory>
+#include <string>
+#include <utility>
 namespace nebula::drivers
 {
 RobosenseHwInterface::RobosenseHwInterface()

diff --git a/nebula_hw_interfaces/src/nebula_velodyne_hw_interfaces/velodyne_hw_interface.cpp b/nebula_hw_interfaces/src/nebula_velodyne_hw_interfaces/velodyne_hw_interface.cpp
@@ -2,6 +2,11 @@
 
 #include "nebula_hw_interfaces/nebula_hw_interfaces_velodyne/velodyne_hw_interface.hpp"
 
+#include <iostream>
+#include <memory>
+#include <string>
+#include <utility>
+
 namespace nebula::drivers
 {
 VelodyneHwInterface::VelodyneHwInterface()

diff --git a/nebula_hw_interfaces/test/common/test_udp.cpp b/nebula_hw_interfaces/test/common/test_udp.cpp
@@ -17,6 +17,7 @@
 #include <optional>
 #include <string>
 #include <thread>
+#include <utility>
 #include <vector>
 
 namespace nebula::drivers::connections

diff --git a/nebula_ros/src/continental/continental_ars548_decoder_wrapper.cpp b/nebula_ros/src/continental/continental_ars548_decoder_wrapper.cpp
@@ -18,6 +18,12 @@
 
 #include <pcl_conversions/pcl_conversions.h>
 
+#include <algorithm>
+#include <memory>
+#include <string>
+#include <unordered_set>
+#include <utility>
+
 namespace nebula::ros
 {
 ContinentalARS548DecoderWrapper::ContinentalARS548DecoderWrapper(

diff --git a/nebula_ros/src/continental/continental_ars548_hw_interface_wrapper.cpp b/nebula_ros/src/continental/continental_ars548_hw_interface_wrapper.cpp
@@ -19,6 +19,8 @@
 #include <tf2_ros/buffer.h>
 #include <tf2_ros/transform_listener.h>
 
+#include <memory>
+
 namespace nebula::ros
 {
 

diff --git a/nebula_ros/src/continental/continental_ars548_ros_wrapper.cpp b/nebula_ros/src/continental/continental_ars548_ros_wrapper.cpp
@@ -16,6 +16,12 @@
 
 #include <nebula_common/util/string_conversions.hpp>
 
+#include <cstdio>
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 #pragma clang diagnostic ignored "-Wbitwise-instead-of-logical"
 
 namespace nebula::ros

diff --git a/nebula_ros/src/continental/continental_srr520_decoder_wrapper.cpp b/nebula_ros/src/continental/continental_srr520_decoder_wrapper.cpp
@@ -18,6 +18,10 @@
 
 #include <pcl_conversions/pcl_conversions.h>
 
+#include <memory>
+#include <unordered_set>
+#include <utility>
+
 namespace nebula::ros
 {
 ContinentalSRR520DecoderWrapper::ContinentalSRR520DecoderWrapper(

diff --git a/nebula_ros/src/continental/continental_srr520_hw_interface_wrapper.cpp b/nebula_ros/src/continental/continental_srr520_hw_interface_wrapper.cpp
@@ -19,6 +19,9 @@
 #include <tf2_ros/buffer.h>
 #include <tf2_ros/transform_listener.h>
 
+#include <algorithm>
+#include <memory>
+
 namespace nebula::ros
 {
 

diff --git a/nebula_ros/src/continental/continental_srr520_ros_wrapper.cpp b/nebula_ros/src/continental/continental_srr520_ros_wrapper.cpp
@@ -16,6 +16,12 @@
 
 #include <nebula_common/util/string_conversions.hpp>
 
+#include <cstdio>
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 #pragma clang diagnostic ignored "-Wbitwise-instead-of-logical"
 
 namespace nebula::ros

diff --git a/nebula_ros/src/hesai/decoder_wrapper.cpp b/nebula_ros/src/hesai/decoder_wrapper.cpp
@@ -7,7 +7,10 @@
 #include <rclcpp/logging.hpp>
 #include <rclcpp/time.hpp>
 
+#include <algorithm>
 #include <memory>
+#include <tuple>
+#include <utility>
 
 #pragma clang diagnostic ignored "-Wbitwise-instead-of-logical"
 namespace nebula::ros

diff --git a/nebula_ros/src/hesai/hesai_ros_wrapper.cpp b/nebula_ros/src/hesai/hesai_ros_wrapper.cpp
@@ -9,12 +9,16 @@
 #include <nebula_common/util/string_conversions.hpp>
 #include <nebula_decoders/nebula_decoders_common/angles.hpp>
 
+#include <algorithm>
 #include <cstdint>
+#include <cstdio>
 #include <filesystem>
 #include <memory>
 #include <sstream>
 #include <stdexcept>
 #include <string>
+#include <utility>
+#include <vector>
 
 #pragma clang diagnostic ignored "-Wbitwise-instead-of-logical"
 

diff --git a/nebula_ros/src/hesai/hw_monitor_wrapper.cpp b/nebula_ros/src/hesai/hw_monitor_wrapper.cpp
@@ -13,6 +13,8 @@
 
 #include <memory>
 #include <string>
+#include <utility>
+#include <vector>
 
 namespace nebula::ros
 {

diff --git a/nebula_ros/src/robosense/decoder_wrapper.cpp b/nebula_ros/src/robosense/decoder_wrapper.cpp
@@ -2,6 +2,12 @@
 
 #include "nebula_ros/robosense/decoder_wrapper.hpp"
 
+#include <algorithm>
+#include <cstdio>
+#include <memory>
+#include <tuple>
+#include <utility>
+
 namespace nebula::ros
 {
 

diff --git a/nebula_ros/src/robosense/hw_interface_wrapper.cpp b/nebula_ros/src/robosense/hw_interface_wrapper.cpp
@@ -4,6 +4,8 @@
 
 #include <nebula_common/util/string_conversions.hpp>
 
+#include <memory>
+
 namespace nebula::ros
 {
 RobosenseHwInterfaceWrapper::RobosenseHwInterfaceWrapper(