Skip to content

Commit

Permalink
test(hesai): rewrite reference data to reflect edge effects of new sc…
Browse files Browse the repository at this point in the history
…an cutting

The new scan cutting mechanism filters points based on the corrected angle. This changes the points contained/filtered out at the edges of the scan cut.
  • Loading branch information
mojomex committed Jul 2, 2024
1 parent ace2724 commit a11abca
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 2 deletions.
Binary file modified nebula_tests/data/hesai/40p/1673400149711850138.pcd
Binary file not shown.
Binary file modified nebula_tests/data/hesai/64/1673403880898440686.pcd
Binary file not shown.
Binary file modified nebula_tests/data/hesai/at128/1679653308704927652.pcd
Binary file not shown.
Binary file modified nebula_tests/data/hesai/qt64/1673401196087570870.pcd
Binary file not shown.
Binary file modified nebula_tests/data/hesai/xt32/1673400678101968885.pcd
Binary file not shown.
Binary file modified nebula_tests/data/hesai/xt32m/1660893203292679064.pcd
Binary file not shown.
8 changes: 6 additions & 2 deletions nebula_tests/hesai/hesai_ros_decoder_test_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@
#include "hesai_common.hpp"
#include "hesai_ros_decoder_test.hpp"

#include <pcl/impl/point_types.hpp>
#include <rclcpp/rclcpp.hpp>

#include <gtest/gtest.h>
#include <pcl/conversions.h>
#include <pcl/io/pcd_io.h>
#include <pcl/point_cloud.h>

#include <cstdlib>
#include <ctime>
Expand Down Expand Up @@ -39,7 +43,7 @@ TEST_P(DecoderTest, TestPcd)
rcpputils::fs::path bag_dir(hesai_driver_->params_.bag_path);
rcpputils::fs::path pcd_dir = bag_dir.parent_path();

pcl::PointCloud<pcl::PointXYZ>::Ptr ref_pointcloud(new pcl::PointCloud<pcl::PointXYZ>);
auto ref_pointcloud = std::make_shared<pcl::PointCloud<pcl::PointXYZ>>();
int check_cnt = 0;

auto scan_callback = [&](
Expand All @@ -58,7 +62,7 @@ TEST_P(DecoderTest, TestPcd)
checkPCDs(pointcloud, ref_pointcloud);
check_cnt++;
// ref_pointcloud.reset(new nebula::drivers::NebulaPointCloud);
ref_pointcloud.reset(new pcl::PointCloud<pcl::PointXYZ>);
ref_pointcloud = std::make_shared<pcl::PointCloud<pcl::PointXYZ>>();
}
};

Expand Down

0 comments on commit a11abca

Please sign in to comment.