-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct azimuth offset #112
Conversation
Signed-off-by: badai-nguyen <[email protected]>
df92358
to
c407d65
Compare
Signed-off-by: badai-nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the corrections. I reviewed the logic and it seems you are correct about the application of rotation correction.
However, because the conversion from polar to euclidean has now changed, tests fail for VLS128.
This may need a bit more investigation to confirm which is correct - each point position is slightly different, and while it looks like rounding differences, some are at the second decimal place so almost centimeter level.
@amc-nu can you also please have a quick look at this?
Signed-off-by: badai-nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This reverts commit 5e587ba.
PR Type
Related Links
TIER IV INTERNAL LINK
Description
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks