Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct azimuth offset #112

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jan 9, 2024

PR Type

  • Bug Fix

Related Links

TIER IV INTERNAL LINK

Description

  • This PR to correct the insufficient of azimuth-offset correction for output azimuth field for vls128.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@badai-nguyen badai-nguyen force-pushed the fix/add_azimuth_correction branch from df92358 to c407d65 Compare January 22, 2024 07:01
@badai-nguyen badai-nguyen marked this pull request as ready for review January 22, 2024 07:04
@drwnz drwnz self-requested a review January 22, 2024 07:10
@drwnz drwnz added the bug Something isn't working label Jan 22, 2024
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the corrections. I reviewed the logic and it seems you are correct about the application of rotation correction.
However, because the conversion from polar to euclidean has now changed, tests fail for VLS128.
This may need a bit more investigation to confirm which is correct - each point position is slightly different, and while it looks like rounding differences, some are at the second decimal place so almost centimeter level.
@amc-nu can you also please have a quick look at this?

@badai-nguyen badai-nguyen requested a review from amc-nu March 19, 2024 09:52
@drwnz drwnz self-requested a review March 19, 2024 10:04
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drwnz drwnz merged commit 5e587ba into tier4:main Mar 19, 2024
6 checks passed
drwnz added a commit that referenced this pull request Mar 19, 2024
badai-nguyen added a commit to badai-nguyen/nebula that referenced this pull request Mar 29, 2024
amc-nu pushed a commit that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants