Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Hesai TCP config script #119

Merged
merged 10 commits into from
Mar 6, 2024
Merged

feat: add Hesai TCP config script #119

merged 10 commits into from
Mar 6, 2024

Conversation

amc-nu
Copy link
Contributor

@amc-nu amc-nu commented Feb 21, 2024

PR Type

  • New Feature

Related Links

Description

Develop and test a configuration script to quickly and easily:

  • Verify and display in the terminal all the current sensor configurations provided by the commands:
    PTC_COMMAND_GET_CONFIG_INFO
    PTC_COMMAND_GET_LIDAR_STATUS
    PTC_COMMAND_GET_PTP_CONFIG
  • Setup the sensor:
  • IP address
  • Destination IP
  • Port
  • Data Port

For the Hesai Pandar QT128 and Pandat OT128 sensors.

Review Procedure

  • Connect a sensor
  • Setup IP address in the Os to match the sensor IP subnet
    Execute the script using the provided instructions:

$ python scripts/hesai_config.py --help

usage: hesai_config.py [-h] [--sensor-ip SENSOR_IP] [--destination-ip DESTINATION_IP] [--data-port DATA_PORT]
                       [--new-sensor-ip NEW_SENSOR_IP] [--mask MASK]

options:
  -h, --help            show this help message and exit
  --sensor-ip SENSOR_IP
                        The current sensor IP address
  --destination-ip DESTINATION_IP
                        Change the current destination IP address to the given one
  --data-port DATA_PORT
                        Change the current destination LiDAR data port to the given one
  --new-sensor-ip NEW_SENSOR_IP
                        Change the current sensor IP address to the given one
  --mask MASK           Change the current net mask to the given one. You can pass it in either a CIDR notation or dotted-decimal
                        notation.

Remarks

Only tested with Hesai Pandar128E4X and PandarQT128.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@amc-nu amc-nu requested a review from drwnz February 21, 2024 06:33
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor changes, but the tool is great. Thank you!

@drwnz drwnz merged commit 910d12b into main Mar 6, 2024
7 checks passed
@drwnz drwnz deleted the hesai_config branch March 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants