Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add range parameter for hesai #120

Conversation

yukkysaito
Copy link
Collaborator

@yukkysaito yukkysaito commented Feb 22, 2024

Signed-off-by: Yukihiro Saito [email protected]

PR Type

  • New Feature

Related Links

Description

The XT-32 has been tested and confirmed to work on the actual device.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: Yukihiro Saito <[email protected]>
@yukkysaito yukkysaito changed the title add range parameter feat: add range parameter for hesai Feb 22, 2024
@yukkysaito yukkysaito changed the base branch from main to feat/range_param_for_hesai February 22, 2024 06:43
@yukkysaito yukkysaito marked this pull request as ready for review February 22, 2024 06:43
@yukkysaito yukkysaito merged commit a35b2f1 into tier4:feat/range_param_for_hesai Feb 22, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant