Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(continental_srvs): fix dependencies #139

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Apr 17, 2024

PR Type

  • Bug Fix

Related Links

ament_cmake_auto is use in CMakeLists.txt but not declared as a dependency in package.xml

Description

Add ament_cmake_auto to package.xml

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@esteve
Copy link
Contributor Author

esteve commented Apr 17, 2024

@knzo25 @xmfcx @mitsudome-r please review this PR when you have a moment, the autoware-deb-packages CI (https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/8696242137/job/23849118285?pr=83) won't build without this change. Thanks.

@knzo25 knzo25 self-requested a review April 17, 2024 10:58
Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Apologies for missing that one 🙇

@esteve
Copy link
Contributor Author

esteve commented Apr 17, 2024

@knzo25 thank you for the prompt review, could you merge this PR? I don't have merge access. Thanks.

@mojomex mojomex merged commit a044108 into tier4:main Apr 17, 2024
6 checks passed
@esteve esteve deleted the fix-dependencies-continental-srvs branch April 17, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants