-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix pre-commit config and adapt code to make all checks pass #162
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #162 +/- ##
==========================================
Coverage ? 14.13%
==========================================
Files ? 82
Lines ? 7585
Branches ? 1179
==========================================
Hits ? 1072
Misses ? 5679
Partials ? 834
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…d between main..develop
…ang-format file check pass
…isfy yamllint and ignore them in prettier to prevent conflicting styles
…mllint/clang-tidy respectively
205e156
to
c2d15eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Type
Description
This PR is a preliminary step to
and makes pre-commit pass on the current codebase.
This involved:
pre-commit is now passing.
Review Procedure
Make sure to check "hide whitespace" and click apply/reload in the "changed files" view's settings when reviewing:
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks