fix(hesai_ros_wrapper): demote calibration fallback message to WARN #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
When Nebula runs without a live Hesai sensor, it will search for an already-downloaded calibration file. If that is not found, it will log a message which was previously at log level
ERROR
.As quite a common workflow is to decode recorded packets on a different machine without this downloaded file, it is more reasonable to demote this to
WARN
.After the warning is emitted, Nebula falls back to a sensor-specific, generic calibration file and continues operation.
With #243, calibration data could be recorded alongside
/pandar_packets
and replayed on any machine, making this file handling routine obsolete. Pointclouds could also be perfectly reproduced without any extra steps.Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks