Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hesai_ros_wrapper): demote calibration fallback message to WARN #244

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Dec 3, 2024

PR Type

  • Improvement

Related Links

Description

When Nebula runs without a live Hesai sensor, it will search for an already-downloaded calibration file. If that is not found, it will log a message which was previously at log level ERROR.
As quite a common workflow is to decode recorded packets on a different machine without this downloaded file, it is more reasonable to demote this to WARN.

After the warning is emitted, Nebula falls back to a sensor-specific, generic calibration file and continues operation.

With #243, calibration data could be recorded alongside /pandar_packets and replayed on any machine, making this file handling routine obsolete. Pointclouds could also be perfectly reproduced without any extra steps.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Dec 3, 2024
@mojomex mojomex requested a review from drwnz December 3, 2024 01:22
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c53b4fd) to head (41303f5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nebula_ros/src/hesai/hesai_ros_wrapper.cpp 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c53b4fd) and HEAD (41303f5). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (c53b4fd) HEAD (41303f5)
total 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #244       +/-   ##
==========================================
- Coverage   26.11%   0.00%   -26.12%     
==========================================
  Files         101      88       -13     
  Lines        9213    7872     -1341     
  Branches     2212     939     -1273     
==========================================
- Hits         2406       0     -2406     
- Misses       6418    7872     +1454     
+ Partials      389       0      -389     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex merged commit e8df4eb into main Dec 3, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants