Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mask-based pruning filter (vendor independent) #250

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Jan 15, 2025

PR Type

  • New Feature

Related Links

Description

ℹ️ This PR provides only a library, and does not have an effect by itself. Vendor implementations are done in PRs following this one.

ℹ️ Performance measurements are provided on a per-vendor basis (e.g. #251) and are thus not included in this PR.

This PR introduces a mask-based pointcloud filter that allows precise pruning of the pointcloud with different pruning factors for different areas of the pointcloud.

This feature is aimed at reducing computational load later in the pipeline by

  • offering a replacement to filters like CropBox
  • providing a way to downsample pointcloud angular resolution in certain areas

The filter takes a grayscale PNG image with the x direction representing azimuth, and the y direction representing the channel - a representation for elevation instead of channel will be added once such sensors are in Nebula.

Points falling into

  • white regions (255 = 100 %) are all kept
  • black regions (0 = 0 %) are all discarded
  • gray regions are filtered according to a dithered black-and-white version of the mask computed on startup

The dithering algorithm first quantizes the grayscale image into multiples of 1/10, yielding 11 quantization levels.
Dithering patterns are diagonal lines spaced as uniformally as possible in a 10-pixel period (both horizontally and vertically).

See the docs for images and behavior descriptions.

Review Procedure

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

The filter takes a path to a PNG image (will be converted to grayscale) and expected resolution/channel count of the mask.

The grayscale mask is then dithered into a black/white mask of the same dimensions, and an `excluded(NebulaPoint const&)` function is provided to test whether a point shall be excluded according to the mask.

For debug purposes, the dithered mask is written to the same directory as the input mask, with the file ending changed to `_dithered.png`. If this fails, the filter will not throw but log a warning.

Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex mojomex force-pushed the feat/universal-downsample branch from 7ea8836 to 5b487be Compare January 16, 2025 03:33
@mojomex mojomex self-assigned this Jan 16, 2025
@mojomex mojomex marked this pull request as ready for review January 16, 2025 04:48
@mojomex mojomex requested a review from drwnz January 16, 2025 04:48
@mojomex mojomex changed the title Feat/universal downsample feat: mask-based pruning filter (vendor independent) Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 74.25743% with 26 lines in your changes missing coverage. Please review.

Project coverage is 26.15%. Comparing base (97959dd) to head (91fc4b8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._decoders_common/point_filters/downsample_mask.hpp 68.62% 14 Missing and 2 partials ⚠️
...oders/tests/point_filters/test_downsample_mask.cpp 79.59% 0 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   26.07%   26.15%   +0.08%     
==========================================
  Files         101      107       +6     
  Lines        9232     9477     +245     
  Branches     2213     2276      +63     
==========================================
+ Hits         2407     2479      +72     
- Misses       6436     6598     +162     
- Partials      389      400      +11     
Flag Coverage Δ
differential 26.15% <74.25%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex requested a review from knzo25 January 17, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant