Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hesai_decoder replace mktime with timegm #78

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

amc-nu
Copy link
Contributor

@amc-nu amc-nu commented Sep 20, 2023

PR Type

  • Bug Fix

Description

Hesai Decoder. Replace std::mktime with timegm to take into consideration non UTC times.

Review Procedure

  • Play a rosbag with pandar_packets msg
  • Launch the hesai_decoder corresponding to the packets being played.
  • Confirm the decoded timestamp matches the current Time Zone.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@amc-nu amc-nu requested review from mojomex, 0x126 and drwnz September 20, 2023 00:02
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz merged commit 99d3560 into main Sep 22, 2023
7 checks passed
@mojomex mojomex deleted the fix-time-decoding branch September 22, 2023 09:26
@mojomex mojomex mentioned this pull request Oct 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants