arch/arm64/lspi: improve spi initialization #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The priv->refcount doesn't actually work as a reference counter, since the bus can't be uninitialized and refcount doesn't count downwards there. Maybe also add an "uninitialize" function to count down priv->refcount, and from there call the disable when the count goes to 0. Just to have the refcount fully implemented.... Then work this to upstream |
joukkone
force-pushed
the
imx9_spi_init
branch
from
f7a50c9 to
953dee1
Compare
jlaitine
reviewed
Nov 19, 2024
arch/arm64/src/imx9/imx9_lpspi.c
Outdated
| { | ||
| struct imx9_lpspidev_s *priv = (struct imx9_lpspidev_s *)dev; | ||
|
|
||
| if (priv->refcount == 1) |
There was a problem hiding this comment.
Why not just first decrease refcount (if refcount > 0) and then disable if refcount == 0 ?
jlaitine
reviewed
Nov 19, 2024
arch/arm64/src/imx9/imx9_lpspi.c
Outdated
|
|
||
| if (priv->refcount == 1) | ||
| { | ||
| imx9_lpspibus_disable(priv->bus_number); |
There was a problem hiding this comment.
I feel bus_number is unnecessary... why not just pass the "struct spi_dev_s *dev" to the "disable".
joukkone
force-pushed
the
imx9_spi_init
branch
from
953dee1 to
97ed43e
Compare
jlaitine
reviewed
Nov 19, 2024
joukkone
force-pushed
the
imx9_spi_init
branch
from
97ed43e to
660b6d8
Compare
jlaitine
approved these changes
Nov 19, 2024
jlaitine
reviewed
Nov 19, 2024
arch/arm64/src/imx9/imx9_lpspi.c
Outdated
| if (priv->refcount == 0) | ||
| { | ||
| imx9_lpspi_modifyreg32(priv, | ||
| IMX9_LPSPI_CR_OFFSET, LPSPI_CR_MEN, 0); |
Hardware initialization is based refcount, not spi enable bit and add interface to unitialize bus Signed-off-by: Jouni Ukkonen <[email protected]>
joukkone
force-pushed
the
imx9_spi_init
branch
from
660b6d8 to
fa638ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardware initialization is based refcount, not
spi enable bit. Interface to disable selected bus
added
Summary
Impact
Testing