Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embedding/openai: fix method-dependent embedding discrepancy #357

Merged
merged 1 commit into from
Nov 18, 2023
Merged

embedding/openai: fix method-dependent embedding discrepancy #357

merged 1 commit into from
Nov 18, 2023

Conversation

eliben
Copy link
Collaborator

@eliben eliben commented Nov 18, 2023 •
edited
Loading

For #356

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Passes all golangci-lint checks.

@eliben eliben mentioned this pull request Nov 18, 2023
Closed
@tmc
Copy link
Owner

tmc commented Nov 18, 2023

Thanks for your contribution!

tmc
tmc approved these changes Nov 18, 2023
View reviewed changes
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmc tmc merged commit 65725eb into tmc:main Nov 18, 2023
@eliben eliben mentioned this pull request Nov 19, 2023
Merged
9 tasks
eliben added a commit to eliben/langchaingo that referenced this pull request Nov 20, 2023
@eliben
embeddings: use EmbedderClient for openai embeddings
35140b3 
Applies the refactored code in tmc#357 to remove duplicated code here.

Updates tmc#356
@eliben eliben mentioned this pull request Nov 20, 2023
Merged
7 tasks
eliben added a commit to eliben/langchaingo that referenced this pull request Nov 20, 2023
@eliben
embeddings: use EmbedderClient for ollama embeddings
fc2c13a 
Applies the refactored code in tmc#357 to remove duplicated code here.

Updates tmc#356
@eliben eliben mentioned this pull request Nov 20, 2023
Merged
7 tasks
tmc pushed a commit that referenced this pull request Nov 21, 2023
@eliben
embeddings: use EmbedderClient for ollama embeddings (#360)
22f9723 
Applies the refactored code in #357 to remove duplicated code here.

Updates #356
tmc pushed a commit that referenced this pull request Nov 21, 2023
@eliben
embeddings: use EmbedderClient for openai embeddings (#359)
ce67575 
Applies the refactored code in #357 to remove duplicated code here.

Updates #356
tmc pushed a commit that referenced this pull request Dec 5, 2023
@eliben @tmc
embedding/openai: fix method-dependent embedding discrepancy (#357)
9ab665a 
Fix method-dependent embedding discrepancy for OpenAI

For #356
tmc pushed a commit that referenced this pull request Dec 5, 2023
@eliben @tmc
embeddings: use EmbedderClient for ollama embeddings (#360)
0a47b26 
Applies the refactored code in #357 to remove duplicated code here.

Updates #356
tmc pushed a commit that referenced this pull request Dec 5, 2023
@eliben @tmc
embeddings: use EmbedderClient for openai embeddings (#359)
f529ffe 
Applies the refactored code in #357 to remove duplicated code here.

Updates #356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmc tmc tmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliben @tmc