B 21997 UI order #14532
Merged
B 21997 UI order #14532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge latest main
Merge main
|
antgmann
requested review from
MInthavongsay,
r-mettler,
ajlusk and
CoryKleinjanCACI
r-mettler
approved these changes
Jan 7, 2025
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
CoryKleinjanCACI
approved these changes
Jan 9, 2025
antgmann
requested review from
MInthavongsay,
r-mettler,
CoryKleinjanCACI and
ajlusk
|
We will need to push the test file change into INT first then we can push this one into main. |
Merged
|
r-mettler
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21977
INT PR
Note
Commit 1817b65 is the result of removing some duplicated text that was somehow added as new lines instead of edited lines when resolving merge conflicts with main. After this commit, everything matches nicely with int and the correct information is shown on the page.
Warning
01d0b77, a3dbb61 were added on this PR and have since also been merged to integration. See below link for this second PR. They introduce tests to improve coverage, as this is the first ticket that went in after differentiating the main/int client test coverage baseline, causing a pass on int and a fail on main. Note that I wanted to also add tests to cover the checkValidRolesWithPrivileges function, but I was having issues getting them to work properly and it's difficult to debug as we no longer allow users to select roles improperly. Due to this commit and diff being tests only, an int pr was created here.
Summary
This PR alters what roles are eligible for supervisor privileges. It is downstream of B-21553
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.