Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21997 int order #14582

Merged
merged 75 commits into from
Jan 16, 2025
Merged

B 21997 int order #14582

merged 75 commits into from
Jan 16, 2025

Conversation

antgmann
Copy link
Contributor

@antgmann antgmann commented Jan 14, 2025

Increases test coverage per requirements for #14532

All changes that are not src/components/Admin/ImportOfficeUserButton/validation.test.js are due to differences between int and main.

loganwc and others added 30 commits December 16, 2024 17:08
…im-Shipment-Create' into B-21460-Fix-Prime-Sim-Shipment-Create
@antgmann antgmann added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Jan 14, 2025
@antgmann antgmann self-assigned this Jan 14, 2025
@antgmann antgmann requested review from a team as code owners January 14, 2025 22:15
@antgmann antgmann mentioned this pull request Jan 14, 2025
12 tasks
r-mettler
r-mettler previously approved these changes Jan 14, 2025
ajlusk
ajlusk previously approved these changes Jan 15, 2025
Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New test looks good.

I've never seen so many direct to main changes in an INT PR but they all look right from what I've checked.

@antgmann antgmann dismissed stale reviews from r-mettler and ajlusk via d98d2b8 January 16, 2025 17:42
Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve after conflict resolution.

@antgmann antgmann merged commit 12c4d17 into integrationTesting Jan 16, 2025
35 checks passed
@antgmann antgmann deleted the B-21997-INT-Order branch January 16, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.