Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21961: Add Requested Office Users List Sorting and Filtering #14651

Conversation

TevinAdams
Copy link
Contributor

Agility ticket

Summary

In this PR the following has been added :

  1. Roles added to the Requested Office Users List
  2. A filter for Transportation Office
  3. A filter for Roles

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access the admin app

  2. Go to the Requested Office Users Tab

  3. Notice the roles are now showing on the list
    image

  4. Type in the Transportation Office Filter - I typed USAF
    image

  5. Type into the Roles Filter - I typed "Ta" for Task Ordering and Task Invoicing
    image

  6. Type into both filter
    image

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@TevinAdams TevinAdams added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Jan 24, 2025
@TevinAdams TevinAdams self-assigned this Jan 24, 2025
@TevinAdams TevinAdams requested review from a team as code owners January 24, 2025 12:08
@robot-mymove
Copy link

robot-mymove commented Jan 24, 2025

Warnings
⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against 96119b1

@ryan-mchugh
Copy link
Contributor

Local Testing

AC says comma separated. On large screen, some of the roles run together as well
image

@TevinAdams
Copy link
Contributor Author

TevinAdams commented Jan 27, 2025

Local Testing

AC says comma separated. On large screen, some of the roles run together as well image

@ryan-mchugh This has been addressed. Roles are separated by a comma and adjustments have been made to the implementation to collapse text when zooming in or out similar to the Id field.

@danieljordan-caci
Copy link
Contributor

Local Testing
AC says comma separated. On large screen, some of the roles run together as well image

@ryan-mchugh This has been addressed. Roles are not separated by a comma and the column collapse text when zooming in or out similar to the Id field.

In your AC it says:

Given I am a MilMove Admin on the admin app,
When I select the "Requested Office Users" menu item,
Then I will see a list of account requests in the status of Requested, with the following fields:

Email
First Name
Last Name
Transportation Office (Real name not UUID)
Status
"Requested On" Date
Roles requested (Comma separated field with all roles requested)

Specifically says it wants them separated by a comma

@TevinAdams
Copy link
Contributor Author

TevinAdams commented Jan 27, 2025

Local Testing
AC says comma separated. On large screen, some of the roles run together as well image

@ryan-mchugh This has been addressed. Roles are not separated by a comma and the column collapse text when zooming in or out similar to the Id field.

In your AC it says:

Given I am a MilMove Admin on the admin app,
When I select the "Requested Office Users" menu item,
Then I will see a list of account requests in the status of Requested, with the following fields:

Email
First Name
Last Name
Transportation Office (Real name not UUID)
Status
"Requested On" Date
Roles requested (Comma separated field with all roles requested)

Specifically says it wants them separated by a comma

@danieljordan-caci I meant to say they are separated by a comma. Did not mean to put "not".
image

Copy link
Contributor

@ryan-mchugh ryan-mchugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor err fixes

ryan-mchugh
ryan-mchugh previously approved these changes Jan 27, 2025
Copy link
Contributor

@ryan-mchugh ryan-mchugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments addressed, approved!

…g' into B-21961-Add-Roles-To-Requested-Office-Users-List-Sorting-INT
ryan-mchugh
ryan-mchugh previously approved these changes Jan 29, 2025
@TevinAdams TevinAdams merged commit 44764c3 into integrationTesting Jan 30, 2025
34 of 35 checks passed
@TevinAdams TevinAdams deleted the B-21961-Add-Roles-To-Requested-Office-Users-List-Sorting-INT branch January 30, 2025 23:35
This was referenced Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

5 participants