Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core) Fix auto-mover hitting wall scenario #4132

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

bieleluk
Copy link
Contributor

@bieleluk bieleluk commented Aug 27, 2024

fixes #3692

@bieleluk bieleluk marked this pull request as ready for review October 24, 2024 13:38
@obrusvit obrusvit added T2B1 Trezor Safe 3 T3B1 labels Oct 24, 2024
@bieleluk
Copy link
Contributor Author

This PR corrects detection of animation start and stop in no wrap-around configuration when the cursor hits the edge.

This issue occurs in "select number of words" menu with no wrap-around, when one arrow is held until the cursor hits the edge and then the other arrow is pressed and held down. The cursor does not start moving back, but it only moves one place.

Changes include:

  1. Adding can_move function to properly detect start and stop of the mover animation.

@bieleluk bieleluk merged commit 7e9aba6 into trezor:main Nov 27, 2024
92 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2B1 Trezor Safe 3 T3B1
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

T2B1: Wrong behavior when auto-mover hits a wall
3 participants