build/docs: running emulator in valgrind #4280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t passed as scons vars so that we don't have to write "USE_FOO=$(USE_FOO)" 20 times every time we add such flag
Here we change all FOO=VALUE defines to be tuples ("FOO", "VALUE").
Also, VALUE is always the raw string you want to end up in the C file,
instead of attempting to shell-escape it while specifying.
By all rights scons _should_ be using shlex.quote() on the CPPDEFINES,
but it doesn't, so we hack it by specifying the define prefix as `-D'`
and suffix as `'`. That way the arguments in shell are '-escaped, and
we're (currently) not using ' in any argument value so this should work
fine.
At the same time, when passing the flags to cargo, we can shlex.quote
the whole thing and get the right strings passed all the way into
build.rs -- as long as no argument contains a comma, which is the split
character...
[no changelog]
[no changelog]
M1nd3r
approved these changes
Oct 24, 2024
docs/core/emulator/valgrind.md
Outdated
| @@ -0,0 +1,34 @@ | |||
| # Profiling emulator with Valgrind | |||
|
|
|||
| Sometimes it can be helpful to know which parts of your code take most of the CPU time. | |||
There was a problem hiding this comment.
NIT: punctuation
Suggested change
| Sometimes it can be helpful to know which parts of your code take most of the CPU time. | |
| Sometimes, it can be helpful to know which parts of your code take most of the CPU time. |
M1nd3r
approved these changes
Oct 24, 2024
hiviah
approved these changes
Oct 24, 2024
matejcik
force-pushed
the
matejcik/scons-vars
branch
7 times, most recently
from
6752623
to
f7d1e6c
Compare
cepetr
force-pushed
the
matejcik/scons-vars
branch
2 times, most recently
from
6f95dd5
to
5b2a1cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some docs and ad-hoc CLI changes to make running emulator in Valgrind easier.
Depends on #4234 as otherwise the build command doesn't work.