Simplify asserts on translations #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
matejcik
force-pushed
the
matejcik/tr-asserts
branch
from
fee17fa to
a1033c0
Compare
matejcik
added
the
translations
obrusvit
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Nice improvement.
I tried to make LSP somehow search for these keys on auto-completion so that you would get hints while writing tests but I had no success.
Tried:
- using
__setattr__in__init__ - overriding
__dir__
The older approach didn't provide any auto-completion support neither though.
we'd probably have to generate a file that has all the available arguments, similar to |
matejcik
force-pushed
the
matejcik/tr-asserts
branch
from
4c6b5c6 to
eb6ed9b
Compare
we need to propagate stacklevel so that the warning is emitted at the usage line instead of deep in translations.py i mean we don't _need_ need to it's just nicer
matejcik
force-pushed
the
matejcik/tr-asserts
branch
from
0bee780 to
2ede124
Compare
this changes UI tests because in edge cases the carousel goes the other (shorter) way
matejcik
force-pushed
the
matejcik/tr-asserts
branch
from
2ede124 to
8b4423e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this change, instead of having to use a cumbersome custom
assert_inassert_in_multipleetc. and mucking around with multiple possible translationsyou instead use the normal assert capabilities, and say things like
assert TR.some__translation_key in debug.text_content(), which any Python reader can decipher.also pytest will point you directly to the failing assertion instead of showing you a problem in the function "assert_equals"
before:
after:
as a bonus, you're actually checking against the currently selected language, which caught a small bug in a couple tests, where language was not re-set after a wipe
TR.regexp("translation__key").match(...)TR.translate(key)(or, you know,getattr(TR, key), but the former is preferable)assert_in_multipleis now significantly wordier, because the operation "in multiple" does not exist in Python. personally I prefer this for clarity, but if it's a big problem we could re-introduce a helper for this situation?