Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix broken flow for changing brightness [no changelog] #4378

Merged
merged 6 commits into from
Nov 26, 2024
Merged

fix(core): fix broken flow for changing brightness [no changelog] #4378

merged 6 commits into from
Nov 26, 2024

Conversation

bieleluk
Copy link
Contributor

@bieleluk bieleluk commented Nov 22, 2024 •
edited
Loading

This PR fixes broken mercury brightness flow introduced by commit 7cf38ec.

Changes include:

  1. Reintroducing success color and icon done in 4334
  2. Setting brightness parameter to Option as uPython requires
  3. Basic UI test (Device test is not possible because the brightness is not among TrezorClientDebugLink features )

@bieleluk bieleluk added bug Something isn't working as expected low hanging fruit Simple, quick task. T3T1 Trezor Safe 5 labels Nov 22, 2024
@bieleluk bieleluk requested a review from obrusvit November 22, 2024 15:48
@bieleluk bieleluk self-assigned this Nov 22, 2024
@bieleluk bieleluk marked this pull request as ready for review November 25, 2024 07:16
@bieleluk bieleluk requested a review from prusnak as a code owner November 25, 2024 07:16
obrusvit
obrusvit approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on emu.
Thank you.

@bieleluk bieleluk added the translations Put this label on a PR to run tests in all languages label Nov 25, 2024
@bieleluk bieleluk requested a review from matejcik as a code owner November 25, 2024 14:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

matejcik
matejcik requested changes Nov 26, 2024
View reviewed changes
tests/input_flows.py Outdated Show resolved Hide resolved
tests/device_tests/test_msg_applysettings.py Outdated Show resolved Hide resolved
@bieleluk bieleluk force-pushed the bieleluk/fix-mercury-brightness-flow branch from 8f51395 to c29ab5c Compare November 26, 2024 15:39
@bieleluk bieleluk merged commit ebc3029 into main Nov 26, 2024
137 of 139 checks passed
@bieleluk bieleluk deleted the bieleluk/fix-mercury-brightness-flow branch November 26, 2024 18:35
@bosomt
Copy link

bosomt commented Nov 28, 2024

QA OK

  • Device: Trezor T3T1 2.8.6 regular (revision 688bddc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik matejcik approved these changes

@obrusvit obrusvit obrusvit approved these changes

@prusnak prusnak Awaiting requested review from prusnak prusnak is a code owner

Assignees

@bieleluk bieleluk

Labels
bug Something isn't working as expected low hanging fruit Simple, quick task. T3T1 Trezor Safe 5 translations Put this label on a PR to run tests in all languages
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bieleluk @bosomt @matejcik @obrusvit