ci: fix bootloader_emu trying to link with ASAN #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
matejcik
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the AddressSanitizer-enabled emulator build job, when building bootloader emulator, the Rust standard library tries to link with ASAN runtime even though we do not support it at all. I don't understand what causes it, possibly rustc/cargo notices that
ADDRESS_SANITIZER=1is set and does this? May or may not be related to #4234.https://github.com/trezor/trezor-firmware/actions/runs/12020560773/job/33509404323
This patch disables bootloader emulator in the job since there's not point in it anyway.