add support for setting BLE name from Trezor firmware #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TychoVrahe
force-pushed
the
tychovrahe/T3W1/bt_name
branch
from
804ee84 to
3259cda
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3W1/bt_name
branch
from
3259cda to
20347e8
Compare
cepetr
requested changes
Jan 17, 2025
core/embed/io/ble/stm32/ble.c
Outdated
| unit_properties_t props; | ||
| unit_properties_get(&props); | ||
|
|
||
| uint8_t data[2 + BLE_ADV_NAME_LEN] = {0}; |
There was a problem hiding this comment.
yes, i added struct for this message f6dc982
core/embed/io/ble/inc/io/ble.h
Outdated
|
|
||
| typedef struct { | ||
| ble_command_type_t cmd_type; | ||
| int connection_id; |
There was a problem hiding this comment.
connection_id seems to be unused now, isn't it?
There was a problem hiding this comment.
Removed 2e5e720.
I will add connection identification later, but it will probably be directly mac address of the central, so no point in keeping this integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the ble_issue_command to support adding data.
Allows sending the name to NRF (this will then be used for advertising and GATT)