Delete all empty parent directories if they are empty #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think this would break existing code that relies on the fact that the parent directory always exists if a file was deleted successfully, for example:
Edit: On second read, it looks like this function should work as it uses try_syscall but there could be other code sites that are affected by this. Maybe limit this to the VFS?
|
I'll limit this to the VFS for now. In the future we can make a test release with it enabled for all filesystem. |
sosthene-nitrokey
force-pushed
the
remove-store-intermediate-upstream
branch
2 times, most recently
from
4e68921 to
c2caa1a
Compare
Merged
sosthene-nitrokey
force-pushed
the
remove-store-intermediate-upstream
branch
from
c2caa1a to
b711d95
Compare
daringer
approved these changes
Dec 13, 2024
This saves a lot of memory since each directory takes at least one block We are starting to see this as an issue because the filesystems are now much deeper due to the SE050
sosthene-nitrokey
force-pushed
the
remove-store-intermediate-upstream
branch
from
b711d95 to
89f037b
Compare
robin-nitrokey
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves a lot of memory since each directory takes at least one block We are starting to see this as an issue because the filesystems are now much deeper due to the SE050