Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default data directory #377

Closed
wants to merge 1 commit into from
Closed

Conversation

ar13pit
Copy link
Contributor

@ar13pit ar13pit commented Mar 7, 2019

Directory to save models for image and speech recognition

Before merging correct the paths in targets (tue-robotics/tue-env-targets#29)

@MatthijsBurgh
Copy link
Member

MatthijsBurgh commented Mar 7, 2019

Check https://github.com/tue-robotics/tue-env/blob/master/setup/tue-data.bash. Data has always been stored in ~/ros/data(/private), so keep it there.
I don't know if this was designed for rosbags, logged data or also models.
Steps to take:

  • First analyse tue-data, maybe ask @Timple or @svddries
  • Design new system/ design updated system
  • Implement it

@ar13pit
Copy link
Contributor Author

ar13pit commented Mar 7, 2019

I did see that but the keras models are being downloaded to a different location
https://github.com/tue-robotics/tue-env-targets/blob/master/ros-image_recognition_keras/install.bash#L3

So thought of generalizing the location. But the question then is why is the keras model not being placed there?

@MatthijsBurgh
Copy link
Member

See updated comment, now I will be offline again.

@ar13pit
Copy link
Contributor Author

ar13pit commented Mar 5, 2020

Closing this PR as this issue needs more discussion and maybe a new design for data management of an env workspace.

@ar13pit ar13pit closed this Mar 5, 2020
@ar13pit ar13pit deleted the feature/default-data-dir branch March 5, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants