-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch testing to Fastlane + add SwiftLint #17
Open
bjtitus
wants to merge
7
commits into
main
Choose a base branch
from
swiftlint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4663c5c
Switches Fastlane scripts for Building and Testing
bjtitus f61f8fe
Add swiftlint and fastlane step for linting
bjtitus df61d6d
Upgrade cocoapods
bjtitus 7adb8f4
Adds Fastlane action to download swiftlint
bjtitus 2397101
Use SwiftLint path from shared Fastlane values
bjtitus d652afd
Some cleanup and README improvements
bjtitus e5bc1b0
Fix Cocoapods instructions
bjtitus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,19 +21,18 @@ jobs: | |
executor: | ||
name: ios/default | ||
xcode-version: "12.0.0" | ||
environment: | ||
SCAN_OUTPUT_DIRECTORY: "output/scan" | ||
steps: | ||
- fix-image | ||
- git/shallow-checkout | ||
- ios/test: | ||
xcode-version: 11.2.1 | ||
workspace: KanvasCameraExample/KanvasCameraExample.xcworkspace | ||
scheme: KanvasCameraExample | ||
device: iPhone 8 | ||
ios-version: "14.0" | ||
bundle-install: true | ||
bundler-working-directory: KanvasCameraExample | ||
pod-install: true | ||
cocoapods-working-directory: KanvasCameraExample | ||
- run: | ||
name: Linting | ||
command: bundle install; bundle exec fastlane lint | ||
- run: | ||
name: Build for Testing | ||
command: bundle install; bundle exec fastlane test | ||
working_directory: KanvasCameraExample | ||
- run: | ||
name: Zip failed diffs | ||
when: always | ||
|
@@ -43,11 +42,16 @@ jobs: | |
name: Save diffs | ||
path: KanvasCameraExample/KanvasCameraExampleTests/diffoutput.zip | ||
destination: testresults | ||
- store_test_results: | ||
path: ./KanvasCameraExample/output/scan | ||
- store_artifacts: | ||
path: output | ||
- store_test_results: | ||
path: output/scan | ||
- ios/save-xcodebuild-artifacts | ||
- ios/save-xcodebuild-artifacts: | ||
Comment on lines
+45
to
52
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
result-bundle-path: build/results | ||
#- ios/validate-podspec: | ||
#- run: | ||
#name: Validate Podspec | ||
#xcode-version: '11.5' | ||
#podspec-path: KanvasCamera.podspec.json | ||
#bundle-install: true | ||
#command: bundle exec fastlane podspec | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,14 @@ DerivedData | |
# ignore snapshot failure files | ||
**/FailureDiffs/* | ||
|
||
# Dependencies | ||
/vendor/ | ||
|
||
# Fastlane | ||
fastlane/Preview.html | ||
fastlane/report.xml | ||
fastlane/README.md | ||
|
||
KanvasCameraExample/Pods/* | ||
!KanvasCameraExample/Pods/Target\ Support\ Files/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can remove this line, since you're deleting those files too. |
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
whitelist_rules: # Rules to run | ||
- control_statement | ||
- force_cast | ||
- force_try | ||
- force_unwrapping | ||
- colon | ||
- trailing_semicolon | ||
- trailing_newline | ||
- legacy_constant | ||
- overridden_super_call | ||
- prohibited_super_call | ||
- unused_enumerated | ||
- implicitly_unwrapped_optional | ||
- custom_rules | ||
- unowned_variable_capture | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
source 'https://rubygems.org' do | ||
gem 'cocoapods', '1.9.1' | ||
gem 'cocoapods', '1.9.3' | ||
gem 'fastlane', '2.165.0' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
source 'https://rubygems.org' do | ||
gem 'cocoapods', '1.9.3' | ||
gem 'fastlane', '2.165.0' | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let' call this "Build and Test"