Upgrade protobuf dependency to 1.36.1, remove retool #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to enable twirp working with the new Protobuf editions/Opaque API[1]. First step to this is updating to the latest go protobuf lib. We need to keep the non-Go files with this, as it's using go:embed to bring in some data. 1: https://go.dev/blog/protobuf-opaque
Wanted to update protoc-gen-go to match the protobuf update. Couldn't get retool to work properly, despite trying several older versions of Go. The project is also archived, so tool the time to switch to simple, Go modules based installs of the tools. This is done without actually changing this library to need modules, support is only flagged in explicitly to install those. This is used to install the version of protoc-gen-go that matches the vendored copy, and the latest version of errcheck is installed. The protoc check script is updated - the versioning scheme has changed, so we now just check a minimum of protoc 3. Generated pb files are re-generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add support for protobuf editions, which requires a newer version of the protobuf module than is currently here. This updates it to the latest released version. Because it makes for a noisy diff, doing the dependency update PR by itself.
I had problems with retool when trying to update
protoc-gen-goto match the vendored protobuf version. Current Go no longer supportsgo getin GOPATH mode. I tried with older builds of Go, but for some reason the tool update wants to fetch a newererrcheckwhich doesn't build on older Go. Because retool appears to be dead anyway (has been archived for ~2.5 years), I removed it and replaced it with module-enabledgo installcommands in the Makefile forerrcheckandprotoc-gen-go. This gives us the same experience as with retool, and doesn't require twirp to become a module.Protoc has changed it's versioning scheme and moved beyond v3, so the check script was updated to handle version 3 or greater.
Generated protobuf code was re-generated with the current generator.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.