Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protobuf dependency to 1.36.1, remove retool #402

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 1 addition & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ Twirp uses github pull requests. Fork, hack away at your changes and submit. Mos

- Add tests that cover your contribution. Overall code coverage should not decrease.
- Twirp officially supports the last 3 releases of Go.
- Protobuf version 3.x.x to generate code with the protoc command.
- For linters and other tools, we use [retool](https://github.com/twitchtv/retool). If `make setup` is not able to install it, you can install it in your path with `go get github.com/twitchtv/retool` and then install tools with `retool build`.
- Protobuf version 3.x.x or later to generate code with the protoc command.

### Running tests

Expand Down
10 changes: 6 additions & 4 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

[[override]]
name = "google.golang.org/protobuf"
version = "1.26.0"
version = "1.36.1"

[[override]]
name = "github.com/pkg/errors"
Expand All @@ -23,3 +23,9 @@
unused-packages = true
go-tests = true
non-go = true

[[prune.project]]
# Protobuf package uses go:embed to include files, so we need to avoid
# pruning them.
name = "google.golang.org/protobuf"
non-go = false
9 changes: 5 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
PATH := ${PWD}/_tools/bin:${PWD}/bin:${PATH}
PATH := ${PWD}/bin:${PATH}
export GO111MODULE=off

all: setup test_all
Expand All @@ -7,8 +7,9 @@ all: setup test_all

setup:
./check_protoc_version.sh
GOPATH="$$PWD/_tools" GOBIN="$$PWD/_tools/bin" go get github.com/twitchtv/retool
./_tools/bin/retool build
# Install dependent tools via modules
GO111MODULE=on GOBIN="$$PWD/bin" go install -v google.golang.org/protobuf/cmd/[email protected]
GO111MODULE=on GOBIN="$$PWD/bin" go install -v github.com/kisielk/[email protected]

generate:
# Recompile and install generator
Expand All @@ -19,7 +20,7 @@ generate:
test_all: setup test test_clientcompat

test: generate
./_tools/bin/errcheck ./internal/twirptest
./bin/errcheck ./internal/twirptest
go test -race ./...

test_clientcompat: generate
Expand Down
3 changes: 0 additions & 3 deletions _tools/.gitignore

This file was deleted.

22 changes: 0 additions & 22 deletions _tools/src/github.com/kisielk/errcheck/LICENSE

This file was deleted.

122 changes: 0 additions & 122 deletions _tools/src/github.com/kisielk/errcheck/README.md

This file was deleted.

Loading