fix({Slice,Map}End): Not allowed with ContinueOnError when instrumented #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compile-time check that verifies that SliceEnd and MapEnd are not allowed with ContinueOnError was part of the function that validates instrumentation. This introduced a bug: if that function returned early because the number of emitters was non-zero, it would never run this check. Fix this and add a failing test case. This allowed a bug in our magic.go example files, because they were using SliceEnd/MapEnd despite ContinueOnError.
r-hang
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compile-time check that verifies that SliceEnd and MapEnd are not
allowed with ContinueOnError
was part of the function that validates instrumentation.
This introduced a bug: if that function returned early
because the number of emitters was non-zero,
it would never run this check.
Fix this and add a failing test case.
This allowed a bug in our magic.go example files,
because they were using SliceEnd/MapEnd despite ContinueOnError.
Found while working on #21.